Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: remove juicefs fuse readiness probe #3435

Conversation

TrafalgarZZZ
Copy link
Member

Ⅰ. Describe what this PR does

Remove juicefs fuse readiness probe.

Ⅱ. Does this pull request fix one issue?

NONE

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
9.2% 9.2% Duplication

@zwwhdls
Copy link
Member

zwwhdls commented Sep 4, 2023

/approve

@codecov
Copy link

codecov bot commented Sep 4, 2023

Codecov Report

Merging #3435 (ec021dd) into master (74930f2) will not change coverage.
The diff coverage is n/a.

❗ Current head ec021dd differs from pull request most recent head 31c0d94. Consider uploading reports for the commit 31c0d94 to get more accurate results

@@           Coverage Diff           @@
##           master    #3435   +/-   ##
=======================================
  Coverage   64.25%   64.25%           
=======================================
  Files         442      442           
  Lines       26424    26424           
=======================================
  Hits        16979    16979           
  Misses       7438     7438           
  Partials     2007     2007           

@cheyang cheyang requested a review from zwwhdls September 4, 2023 09:22
Copy link
Collaborator

@cheyang cheyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@fluid-e2e-bot
Copy link

fluid-e2e-bot bot commented Sep 5, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheyang, zwwhdls

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fluid-e2e-bot fluid-e2e-bot bot merged commit 64ac210 into fluid-cloudnative:master Sep 5, 2023
cheyang pushed a commit to cheyang/fluid that referenced this pull request Sep 5, 2023
)

* Remove useless readiness probe on JuiceFS fuse

Signed-off-by: trafalgarzzz <[email protected]>

* Remove useless readiness probe on JuiceFS fuse

Signed-off-by: trafalgarzzz <[email protected]>

---------

Signed-off-by: trafalgarzzz <[email protected]>
cheyang pushed a commit to cheyang/fluid that referenced this pull request Sep 5, 2023
)

* Remove useless readiness probe on JuiceFS fuse

Signed-off-by: trafalgarzzz <[email protected]>

* Remove useless readiness probe on JuiceFS fuse

Signed-off-by: trafalgarzzz <[email protected]>

---------

Signed-off-by: trafalgarzzz <[email protected]>
Signed-off-by: cheyang <[email protected]>
cheyang added a commit that referenced this pull request Sep 5, 2023
* Remove useless readiness probe on JuiceFS fuse



* Remove useless readiness probe on JuiceFS fuse



---------

Signed-off-by: trafalgarzzz <[email protected]>
Signed-off-by: cheyang <[email protected]>
Co-authored-by: TzZtzt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants