use annotation for exposed affinity for dataflow

[xliuqq]

Ⅰ. Describe what this PR does

user should define annotation for exposed dataflow affinity. see the usage in the doc.

Ⅱ. Does this pull request fix one issue?

fixes #XXXX

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

[TrafalgarZZZ]

@xliuqq @cheyang Is it possible to store affinity information in annotations instead of labels? From my understanding, annotations indicate which labels should be exposed, and dataflow-controller injects key=value pair to DataOperation job's labels. Can we also injecting key=value pair to DataOperation job's annotations?

[TrafalgarZZZ]

I think we should clearly comment here what does "exposed" mean for better code readabiility

[xliuqq]

@xliuqq @cheyang Is it possible to store affinity information in annotations instead of labels? From my understanding, annotations indicate which labels should be exposed, and dataflow-controller injects key=value pair to DataOperation job's labels. Can we also injecting key=value pair to DataOperation job's annotations?

do you mean only store the affinity information in annotations instead of labels for DataOperation Job when it finished ? I agree with this.

[TrafalgarZZZ]

@xliuqq @cheyang Is it possible to store affinity information in annotations instead of labels? From my understanding, annotations indicate which labels should be exposed, and dataflow-controller injects key=value pair to DataOperation job's labels. Can we also injecting key=value pair to DataOperation job's annotations?

do you mean only store the affinity information in annotations instead of labels for DataOperation Job when it finished ? I agree with this.

Yes. All the affinity info DataFlow needs can be injected to annotations.

[cheyang]

@xliuqq @cheyang Is it possible to store affinity information in annotations instead of labels? From my understanding, annotations indicate which labels should be exposed, and dataflow-controller injects key=value pair to DataOperation job's labels. Can we also injecting key=value pair to DataOperation job's annotations?

I also think annotation is better than labels. Thanks.

[cheyang]

@xliuqq Could you please fix the conflict of source file? Thanks.

[cheyang]

/test fluid-e2e

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
46.5% Duplication on New Code

See analysis details on SonarCloud

[cheyang]

/lgtm
/approve

[cheyang]

/test fluid-e2e

[TrafalgarZZZ]

fluid-e2e failed because the port allocator randomly picked the same port for two runtimes. It's a temporary failure
/retest

[TrafalgarZZZ]

/lgtm

[fluid-e2e-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheyang, TrafalgarZZZ

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [TrafalgarZZZ,cheyang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment