Fix: add check mountPath in nodePublishVolume #4392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Syspretor
force-pushed
the
fix/check-mount-path-in-csi-nodePublishVolume
branch
3 times, most recently
from
0595d8d to
477c94e
Compare
cheyang
reviewed
Nov 7, 2024
cheyang
reviewed
Nov 7, 2024
Syspretor
force-pushed
the
fix/check-mount-path-in-csi-nodePublishVolume
branch
from
477c94e to
a19d06d
Compare
Signed-off-by: jiuyu <[email protected]>
Syspretor
force-pushed
the
fix/check-mount-path-in-csi-nodePublishVolume
branch
from
a19d06d to
a46b4f4
Compare
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cheyang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We support a configuration to skip checking mount ready in #4346, to handle the case that user define a nil mountPoints dataset in thinruntime. the verification of the existence of the mountPath was also skipped in the nodePublishVolume function with this configuration. The mountPath was linked to the targetPath using a symlink, which caused the targetPath to be linked to a non-existent directory before the mountPod created it. As a result, the application pod's creation would fail until the fusePod was started and running, which then created the mountPath linked to the targetPath.
In this PR, a pre-check for the existence of the mountPath will be added in the nodePublishVolume method of the CSI plugin.