GPII-1336: update `schemaMiddleware` to work with more than just POST data... #5

the-t-in-rtf · 2015-11-03T14:40:00Z

See GPII-1336 for details.

…ee `README.md` for details about the list of components and their purpose.

…actor.

…of local copy/paste code.

…on to better reflect how it works.

…scapes slashes and tildes in path variables.

…r pull request feedback.

…Z-Schema improvements (and advice from the package author).

…it is supported by Z-Schema.

… middleware.

…e installation and test cycle.

…e schema directory. Also added test content to exercise this.

… required there and breaks things on the server side.

…ad request) instead of 500 (server error).

… exposed password data.

…hould include information about the JSON schema it uses.

…ma resolve dependencies.

…emas.

…ter logging when an invalid schema is supplied.

…oken all-tests.js.

… `validator` output using hints from the schema itself.

…eps.

…ost-2.0.0 binder transform functions and deletion relay fix.

…pressing enter.

the-t-in-rtf · 2017-01-23T14:34:19Z

When we get around to this, we should review all-tests.js together. All of the tests required from all-tests.js pass individually, but fail when run together. I suspect a similar problem in gpii-express-user as well.

…d dependencies based on output of `yarn outdated`.

…pendencies based on output of `yarn outdated`.

the-t-in-rtf · 2017-02-06T11:12:15Z

@amb26, once the gpii-pouchdb pull is merged, it would be good to revisit this one. It's one of the very oldest, and seemed to be trending towards completion when last we left it. I will start working on the test stability in advance of that.

…requirements, and to document the test problems with npm 3.10.10

the-t-in-rtf · 2017-02-06T14:30:02Z

@amb26, after painstaking troubleshooting, I have confirmed that the test failures only occur when running the tests using npm test, and only with npm version 3.10.10. The tests definitely pass when using a 4.x version of npm, and pass with yarn as well. As I have no idea how to localize the problem beyond that, I hope it's acceptable to document the incompatibility and let time take care of the rest. The tests pass in Vagrant, which is configured to use yarn.

amb26 · 2017-02-06T14:42:54Z

I get the following failure when running the tests by any means:

$ yarn test
yarn test v0.19.1
$ node node_modules/.bin/istanbul cover tests/all-tests.js
E:\source\gits\gpii-json-schema\node_modules\.bin\istanbul:2
basedir=$(dirname "$(echo "$0" | sed -e 's,\\,/,g')")
          ^^^^^^^
SyntaxError: missing ) after argument list
    at Object.exports.runInThisContext (vm.js:76:16)
    at Module._compile (module.js:542:28)
    at Object.Module._extensions..js (module.js:579:10)
    at Module.load (module.js:487:32)
    at tryModuleLoad (module.js:446:12)
    at Function.Module._load (module.js:438:3)
    at Module.runMain (module.js:604:10)
    at run (bootstrap_node.js:394:7)
    at startup (bootstrap_node.js:149:9)
    at bootstrap_node.js:509:3
error Command failed with exit code 1.

the-t-in-rtf · 2017-02-07T10:55:27Z

OK, I fixed the problem that was preventing the launch of istanbul, but that only cleared the way to hit the next problem.

I'm currently encountering "address in use" errors not seen on linux or OS X, but only when running the browser tests (they use the same harness as the node tests). I will continue investigating and comment here when I have more information.

the-t-in-rtf · 2017-02-07T12:44:34Z

The "address in use" errors were a red herring (although they did encourage me to do a bit of review and refactoring of the test environments, which isn't a bad thing). It turns out that my problem was that chromedriver wasn't in the path on my windows VM. @amb26, as far as I can see, this is ready for review again.

amb26 · 2017-02-07T13:20:47Z

I've installed chromedriver using npm install -g chromedriver, and verified that it is on the PATH by running "chromedriver" from the command line. Unfortunately for some reason it is still not being picked up by the tests. I get the following error:

13:16:57.354:  jq: Test concluded - Module "Testing 'evolved' error messages..." Test name "Testing preserving a message in an underlying schema...": 1/1 passed
 - PASS
13:16:57.667:  jq: FAIL: Module "chrome: Testing client-side validation..." Test name "chrome: Validate the simplest valid 'base' record...." - Message: Died on
 test #1     at Object.asyncTest (E:\Source\gits\gpii-json-schema\node_modules\infusion\tests\lib\qunit\js\qunit.js:405:9)
    at E:\Source\gits\gpii-json-schema\node_modules\infusion\tests\test-core\utils\js\IoCTestUtils.js:651:29
    at Object.fluid.each (E:\Source\gits\gpii-json-schema\node_modules\infusion\src\framework\core\js\Fluid.js:513:17)
    at Object.fluid.test.processTestCase (E:\Source\gits\gpii-json-schema\node_modules\infusion\tests\test-core\utils\js\IoCTestUtils.js:625:15)
    at E:\Source\gits\gpii-json-schema\node_modules\infusion\tests\test-core\utils\js\IoCTestUtils.js:674:24
    at Object.fluid.each (E:\Source\gits\gpii-json-schema\node_modules\infusion\src\framework\core\js\Fluid.js:513:17)
    at Object.fluid.test.processTestCaseHolder (E:\Source\gits\gpii-json-schema\node_modules\infusion\tests\test-core\utils\js\IoCTestUtils. .... [output suppre
ssed at 1024 chars - for more output, increase fluid.logObjectRenderChars]
13:16:57.671:  jq: Source: Error: The ChromeDriver could not be found on the current PATH. Please download the latest version of the ChromeDriver from http://ch
romedriver.storage.googleapis.com/index.html and ensure it can be found on your PATH.
    at Error (native)
    at ServiceBuilder (E:\Source\gits\gpii-json-schema\node_modules\selenium-webdriver\chrome.js:191:13)
    at getDefaultService (E:\Source\gits\gpii-json-schema\node_modules\selenium-webdriver\chrome.js:280:22)
    at Function.createSession (E:\Source\gits\gpii-json-schema\node_modules\selenium-webdriver\chrome.js:700:44)
    at createDriver (E:\Source\gits\gpii-json-schema\node_modules\selenium-webdriver\index.js:167:33)
    at Builder.build (E:\Source\gits\gpii-json-schema\node_modules\selenium-webdriver\index.js:639:16)
    at gpii.webdriver.init (E:\Source\gits\gpii-json-schema\node_modules\gpii-webdriver\src\js\webdriver.js:53:35)
    at togo (E:\Source\gits\gpii-json-schema\node_modules\infusion\src\framework\core\js\FluidIoC.js:1794:33)
    at Object.fire  .... [output suppressed at 1024 chars - for more output, increase fluid.logObjectRenderChars]
13:16:57.675:  Express server listening on port 6985
13:16:57.675:  Express started...
13:16:57.783:  jq: Test concluded - Module "chrome: Testing client-side validation..." Test name "chrome: Validate the simplest valid 'base' record....": 0/1 pa
ssed - FAIL
13:16:58.104:  jq: FAIL: Module "chrome: Testing client-side validation..." Test name "chrome: Validate the simplest valid 'derived' record...." - Message: Died
 on test #1     at Object.asyncTest (E:\Source\gits\gpii-json-schema\node_modules\infusion\tests\lib\qunit\js\qunit.js:405:9)
    at E:\Source\gits\gpii-json-schema\node_modules\infusion\tests\test-core\utils\js\IoCTestUtils.js:651:29
    at Object.fluid.each (E:\Source\gits\gpii-json-schema\node_modules\infusion\src\framework\core\js\Fluid.js:513:17)
    at Object.fluid.test.processTestCase (E:\Source\gits\gpii-json-schema\node_modules\infusion\tests\test-core\utils\js\IoCTestUtils.js:625:15)
    at E:\Source\gits\gpii-json-schema\node_modules\infusion\tests\test-core\utils\js\IoCTestUtils.js:674:24
    at Object.fluid.each (E:\Source\gits\gpii-json-schema\node_modules\infusion\src\framework\core\js\Fluid.js:513:17)
    at Object.fluid.test.processTestCaseHolder (E:\Source\gits\gpii-json-schema\node_modules\infusion\tests\test-core\utils\js\IoCTestUti .... [output suppresse
d at 1024 chars - for more output, increase fluid.logObjectRenderChars]
13:16:58.107:  jq: Source: Error: The ChromeDriver could not be found on the current PATH. Please download the latest version of the ChromeDriver from http://ch
romedriver.storage.googleapis.com/index.html and ensure it can be found on your PATH.
    at Error (native)
    at ServiceBuilder (E:\Source\gits\gpii-json-schema\node_modules\selenium-webdriver\chrome.js:191:13)
    at getDefaultService (E:\Source\gits\gpii-json-schema\node_modules\selenium-webdriver\chrome.js:280:22)
    at Function.createSession (E:\Source\gits\gpii-json-schema\node_modules\selenium-webdriver\chrome.js:700:44)
    at createDriver (E:\Source\gits\gpii-json-schema\node_modules\selenium-webdriver\index.js:167:33)
    at Builder.build (E:\Source\gits\gpii-json-schema\node_modules\selenium-webdriver\index.js:639:16)
    at gpii.webdriver.init (E:\Source\gits\gpii-json-schema\node_modules\gpii-webdriver\src\js\webdriver.js:53:35)
    at togo (E:\Source\gits\gpii-json-schema\node_modules\infusion\src\framework\core\js\FluidIoC.js:1794:33)
    at Object.fire  .... [output suppressed at 1024 chars - for more output, increase fluid.logObjectRenderChars]
13:16:58.111:  FATAL ERROR: Uncaught exception: listen EADDRINUSE :::6985

amb26 · 2017-02-07T13:30:26Z

Looks like selenium-webdriver's detection of chromedriver is bullshit - it looks explicitly for "chromedriver.exe" in the path - https://github.com/SeleniumHQ/selenium/blob/master/javascript/node/selenium-webdriver/chrome.js#L189 - whereas npm install -g chromedriver only places "chromedriver" and "chromedriver.cmd" on the PATH

amb26 · 2017-02-07T15:30:42Z

I've filed giggio/node-chromedriver#90 against node-chromedriver. I suggest we just add a brief note in the README under the "chromedriver" heading that this npm module is not to be used and that the user must manually follow the install instructions at https://sites.google.com/a/chromium.org/chromedriver/getting-started to download this to their PATH

the-t-in-rtf · 2017-02-08T12:17:35Z

I have updated the README with caveats about the chromedriver install. Thankfully this is no longer needed on the Vagrant linux box, which now finally has its own package.

…r install instructions.

the-t-in-rtf · 2017-02-08T12:19:50Z

I also removed the dev dependency on the chromedriver npm package.

duhrer added 30 commits August 20, 2015 16:25

GPII-1176: Initial implementation and tests for all key components. S…

8763e2d

…ee `README.md` for details about the list of components and their purpose.

GPII-1176: Migrated to new fluid.notImplemented function.

c86f348

GPII-1176: Fixed outdated variable name in server tests following ref…

999ed97

…actor.

GPII-1176: Removed 2ypo in2roduced while lin2ing code.

5dab3f6

GPII-1176: Refactored to use test grades from gpii.express instead …

61053a3

…of local copy/paste code.

GPII-1176: Refactored "resolve target" method and updated documentati…

71791be

…on to better reflect how it works.

GPII-1176: Minor documentation tweak.

75cfd81

GPII-1176: Added handling (and tests) for the way in which Z-schema e…

129df56

…scapes slashes and tildes in path variables.

GPII-1176: Renamed overly general handler and middleware files pe…

d2c839e

…r pull request feedback.

GPII-1176: Fixed bug that prevented Z-Schema options from being used.

fde80a8

GPII-1176: Fixed bug that prevented Z-Schema options from being used.

16cf395

GPII-1176: Improved handling and tests for escaping following recent …

d326642

…Z-Schema improvements (and advice from the package author).

GPII-1176: Removed outdated warning about multiple slashes, now that …

fcbe487

…it is supported by Z-Schema.

GPII-1176: Updated to latest express and fixed middleware tests.

ed2d74e

GPII-1176: Updated to latest gpii.express and confirmed working.

d1ede11

GPII-1176: Updated to latest gpii.express to fix problems with static…

e45a869

… middleware.

GPII-1176: Updated to latest gpii.express to fix problems with static…

a4240ec

… middleware.

GPII-1176: Added bower install to postinstall hook to simplify th…

bdcd5ca

…e installation and test cycle.

GPII-1287: Improved template loading in server-side validator.

a1245d1

GPII-1287: Updated middleware to use the new server-side validator.

49adb08

GPII-1287: Added safety check to avoid loading non-JSON content in th…

caf10cf

…e schema directory. Also added test content to exercise this.

GPII-1287: Moved schema validation to the client grade, as it is only…

ecf5853

… required there and breaks things on the server side.

GPII-1287: Updated HTTP status code on validation error to use 400 (b…

5ce52ac

…ad request) instead of 500 (server error).

GPII-1319: Migrated from z-schema to AJV to work around problems with…

1641ed1

… exposed password data.

GPII-1325: JSON Schema middleware output should itself be valid and s…

a452b5d

…hould include information about the JSON schema it uses.

GPII-1325: Removed orphaned and unused legacy code that helped z-sche…

6c06f63

…ma resolve dependencies.

GPII-1325: Removed redundant and confusing double registration of sch…

1c722ff

…emas.

GPII-1325: Surrounded addSchema with a try catch block to give us bet…

76cc6e4

…ter logging when an invalid schema is supplied.

GPII-1325: Updated all tests to use standard schema keys and fixed br…

aff69f4

…oken all-tests.js.

GPII-1325: Finished basic infrastructure for parser, which improves…

5d1fa02

… `validator` output using hints from the schema itself.

the-t-in-rtf added 7 commits December 7, 2016 18:25

NOJIRA: Added chromedriver to dev dependencies and simplified QI st…

11b7e54

…eps.

NOJIRA: Migrated Travis configuration to use yarn and Node 6.

31c6e56

NOJIRA: Manually installed yarn in Travis config.

82e014d

NOJIRA: Fixed bad formatting in docs based on review of GitHub output.

c217eb8

GPII-2179: Pin to a published version of infusion that includes the p…

03caf53

…ost-2.0.0 binder transform functions and deletion relay fix.

KETTLE-51: Upgrading kettle to pick up utf8 fixes.

fd9838a

GPII-2250: Fixed form submission when changing a text field and then …

95059c1

…pressing enter.

the-t-in-rtf added 2 commits January 27, 2017 15:58

NOJIRA: Updated to 3.0.0 dev release of infusion. Updated all outdate…

8dbab26

…d dependencies based on output of `yarn outdated`.

NOJIRA: Updated gpii-express to released version. Updated outdated de…

f5942e0

…pendencies based on output of `yarn outdated`.

GPII-1336: Updated dependencies and documentation to reflect the new …

206cec3

…requirements, and to document the test problems with npm 3.10.10

the-t-in-rtf added 2 commits February 7, 2017 11:45

GPII-1336: Fixed broken “test” script definition.

d851d7b

GPII-1336: Restored chromedriver as a dev dependency.

cdd6f15

GPII-1336: Refactored and hardened test environment for browser tests.

48de1d6

GPII-1336: Added chromedriver installation caveats.

75c338c

GPII-1336: Removed non-useful chromedriver package in favor of cleare…

71db4cf

…r install instructions.

amb26 merged commit 71db4cf into fluid-project:master Feb 8, 2017

the-t-in-rtf deleted the GPII-1336 branch May 22, 2017 07:31

the-t-in-rtf restored the GPII-1336 branch September 27, 2017 09:27

the-t-in-rtf deleted the GPII-1336 branch October 10, 2017 07:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GPII-1336: update `schemaMiddleware` to work with more than just POST data... #5

GPII-1336: update `schemaMiddleware` to work with more than just POST data... #5

the-t-in-rtf commented Nov 3, 2015

the-t-in-rtf commented Jan 23, 2017

the-t-in-rtf commented Feb 6, 2017

the-t-in-rtf commented Feb 6, 2017

amb26 commented Feb 6, 2017

the-t-in-rtf commented Feb 7, 2017

the-t-in-rtf commented Feb 7, 2017

amb26 commented Feb 7, 2017

amb26 commented Feb 7, 2017

amb26 commented Feb 7, 2017

the-t-in-rtf commented Feb 8, 2017

the-t-in-rtf commented Feb 8, 2017

GPII-1336: update schemaMiddleware to work with more than just POST data... #5

GPII-1336: update schemaMiddleware to work with more than just POST data... #5

Conversation

the-t-in-rtf commented Nov 3, 2015

the-t-in-rtf commented Jan 23, 2017

the-t-in-rtf commented Feb 6, 2017

the-t-in-rtf commented Feb 6, 2017

amb26 commented Feb 6, 2017

the-t-in-rtf commented Feb 7, 2017

the-t-in-rtf commented Feb 7, 2017

amb26 commented Feb 7, 2017

amb26 commented Feb 7, 2017

amb26 commented Feb 7, 2017

the-t-in-rtf commented Feb 8, 2017

the-t-in-rtf commented Feb 8, 2017

GPII-1336: update `schemaMiddleware` to work with more than just POST data... #5

GPII-1336: update `schemaMiddleware` to work with more than just POST data... #5