Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in a recent Fluid Project meeting, there is a limitation with the current Infusion package management strategy which this PR resolves. Right now we are very specific in pinning precise versions of NPM dependencies which guarantees a consistent install for different users and developers. However, without a package lock file, any sub-dependencies will be installed based on version constraints from the top level dependency. So for example:
If we require version
1.2.1
ofsome-package
and it requires version^2.1
ofsome-other-package
, a developer might get version2.1.0
ofsome-other-package
but a month later someone else could run NPM install and end up with version2.2.0
ofsome-other-package
.Keeping the
package-lock.json
file in version control means that both people will get the same version ofsome-other-package
as specified in the lock file.This PR also bumps the Infusion version and adjusts the CI workflows to use the build-in dependency caching from
actions/setup-node
now that we have a lock file to act as the basis for this.