Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit package-lock.json file #72

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

greatislander
Copy link
Contributor

@greatislander greatislander commented Dec 6, 2024

As discussed in a recent Fluid Project meeting, there is a limitation with the current Infusion package management strategy which this PR resolves. Right now we are very specific in pinning precise versions of NPM dependencies which guarantees a consistent install for different users and developers. However, without a package lock file, any sub-dependencies will be installed based on version constraints from the top level dependency. So for example:

If we require version 1.2.1 of some-package and it requires version ^2.1 of some-other-package, a developer might get version 2.1.0 of some-other-package but a month later someone else could run NPM install and end up with version 2.2.0 of some-other-package.

Keeping the package-lock.json file in version control means that both people will get the same version of some-other-package as specified in the lock file.

This PR also bumps the Infusion version and adjusts the CI workflows to use the build-in dependency caching from actions/setup-node now that we have a lock file to act as the basis for this.

@duhrer
Copy link
Contributor

duhrer commented Dec 13, 2024

I'm sure there's a reason we're changing course on this, but it would be good to document the reasoning as part of the change. A summary of the discussion or a link to an issue would be sufficient.

@greatislander
Copy link
Contributor Author

@duhrer I've updated the description, thanks!

@duhrer duhrer self-assigned this Dec 13, 2024
@duhrer duhrer merged commit ff689a5 into fluid-project:main Dec 13, 2024
4 checks passed
@greatislander greatislander deleted the package-lock branch December 13, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants