Skip to content

Commit

Permalink
remove some stale todos (#8786)
Browse files Browse the repository at this point in the history
  • Loading branch information
kenzieschmoll authored Jan 17, 2025
1 parent e2cde7b commit 427efbf
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 9 deletions.
3 changes: 0 additions & 3 deletions packages/devtools_app/lib/src/shared/table/table.dart
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,6 @@ part '_table_column.dart';
part '_table_row.dart';
part '_tree_table.dart';

// TODO(devoncarew): We need to render the selected row with a different
// background color.

typedef IndexedScrollableWidgetBuilder =
Widget Function({
required BuildContext context,
Expand Down
5 changes: 3 additions & 2 deletions packages/devtools_shared/lib/src/server/server_api.dart
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,6 @@ class ServerApi {
}) {
api ??= ServerApi();
final queryParams = request.requestedUri.queryParameters;
// TODO(kenz): break this switch statement up so that it uses helper methods
// for each case. Also use [_checkRequiredParameters] helper.
switch (request.url.path) {
case apiNotifyForVmServiceConnection:
return Handler.handleNotifyForVmServiceConnection(
Expand All @@ -72,6 +70,9 @@ class ServerApi {
dtd,
);

// TODO(kenz): remove legacy analytics once the unified analytics rollout
// is complete and verified for robustness (est. Fall 2025).

// ----- Flutter Tool GA store. -----
case apiGetFlutterGAEnabled:
// Is Analytics collection enabled?
Expand Down
4 changes: 0 additions & 4 deletions tool/lib/commands/update_version.dart
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,6 @@ import 'dart:io';
import 'package:args/command_runner.dart';
import '../utils.dart';

// This script must be executed from the top level devtools/ directory.
// TODO(kenz): If changes are made to this script, first consider refactoring to
// use https://github.com/dart-lang/pubspec_parse.

// All other devtools_* pubspecs have their own versioning strategies, or do not
// have a version at all (in the case of devtools_test).
final _devtoolsAppPubspec = File(
Expand Down

0 comments on commit 427efbf

Please sign in to comment.