Add lint 'discarded_futures'. #4659

polina-c · 2022-10-28T23:57:45Z

No description provided.

packages/devtools_app/test/shared/service_extension_widgets_test.dart

kenzieschmoll · 2022-10-31T17:25:27Z

packages/devtools_app/test/vm_developer/object_inspector/vm_developer_common_widgets_test.dart

    when(mockClassObject.requestRetainingPath()).thenAnswer((_) async {
      retainingPathNotifier.value = testRetainingPath;
    });

    when(mockClassObject.inboundReferences).thenReturn(inboundRefsNotifier);

+    // Intebtionally unwaited.
+    // ignore: discarded_futures


is there a way we can turn this lint off for the test/ directory?

I did not find how to exclude just one lint for a directory.

I think code reader will benefit from seeing that a future is dropped.

CoderDake · 2022-10-31T14:39:00Z

packages/devtools_app/lib/src/framework/release_notes/release_notes.dart

@@ -166,7 +166,8 @@ class ReleaseNotes extends AnimatedWidget {
                : Expanded(
                    child: Markdown(
                      data: markdownData!,
-                      onTapLink: (_, href, __) => launchUrl(href!, context),
+                      onTapLink: (_, href, __) =>


Suggested change

onTapLink: (_, href, __) =>

onTapLink: (_, href, __) async =>

launchUrl(href!, context),

I would like the fixes to go to separate PRs. They may affect functionality and tests. And I do not want this massive PR to be held by this and thus become victim of error-prone merges.

Created bug: #4668

CoderDake · 2022-10-31T14:50:44Z

packages/devtools_app/lib/src/framework/landing_screen.dart

@@ -158,7 +160,8 @@ class _ConnectDialogState extends State<ConnectDialog>
            SizedBox(
              width: scaleByFontFactor(350.0),
              child: TextField(
-                onSubmitted: actionInProgress ? null : (str) => _connect(),
+                onSubmitted:
+                    actionInProgress ? null : (str) => unawaited(_connect()),


Suggested change

actionInProgress ? null : (str) => unawaited(_connect()),

actionInProgress ? null : (str) async => _connect(),

CoderDake · 2022-10-31T14:51:51Z

packages/devtools_app/lib/src/framework/landing_screen.dart

@@ -265,7 +268,7 @@ class ImportFileInstructions extends StatelessWidget {
          ),
          const SizedBox(height: defaultSpacing),
          ElevatedButton(
-            onPressed: () => _importFile(context),
+            onPressed: () => unawaited(_importFile(context)),


Suggested change

onPressed: () => unawaited(_importFile(context)),

onPressed: () async => _importFile(context),

CoderDake · 2022-10-31T14:54:03Z

packages/devtools_app/lib/src/screens/debugger/call_stack.dart

@@ -101,7 +103,7 @@ class _CallStackState extends State<CallStack>
    final result = Material(
      color: selected ? theme.colorScheme.selectedRowColor : null,
      child: InkWell(
-        onTap: () => _onStackFrameSelected(frame),
+        onTap: () => unawaited(_onStackFrameSelected(frame)),


Suggested change

onTap: () => unawaited(_onStackFrameSelected(frame)),

onTap: () async => _onStackFrameSelected(frame),

CoderDake · 2022-10-31T15:06:11Z

packages/devtools_app/lib/src/screens/debugger/variables.dart

@@ -220,7 +222,8 @@ class VariableSelectionControls extends MaterialTextSelectionControls {
      clipboardStatus: clipboardStatus!,
      handleCut: canCut(delegate) ? () => handleCut(delegate) : null,
      handleCopy: canCopy(delegate) ? () => handleCopy(delegate) : null,
-      handlePaste: canPaste(delegate) ? () => handlePaste(delegate) : null,
+      handlePaste:
+          canPaste(delegate) ? () => unawaited(handlePaste(delegate)) : null,


Suggested change

canPaste(delegate) ? () => unawaited(handlePaste(delegate)) : null,

canPaste(delegate) ? () => unawaited(handlePaste(delegate)) : null,

CoderDake · 2022-10-31T17:23:55Z

packages/devtools_app/test/shared/instance_viewer_test.dart

@@ -121,7 +121,7 @@ final enumValueInstance = AsyncValue.data(
 );

 void main() {
-  setUpAll(() => loadFonts());
+  setUpAll(() async => await loadFonts());


Suggested change

setUpAll(() async => await loadFonts());

setUpAll(() async => loadFonts());

CoderDake · 2022-10-31T17:27:42Z

packages/devtools_app/test/shared/service_extension_widgets_test.dart

@@ -30,6 +30,9 @@ void main() {

    setUp(() {
      reloads = 0;
+
+      // Intebtionally unwaited.


Suggested change

// Intebtionally unwaited.

// Intentionally unwaited.

y

You could also make the setup closure async instead
setUp(() async {

CoderDake · 2022-10-31T17:28:58Z

packages/devtools_app/test/shared/service_extension_widgets_test.dart

@@ -81,6 +84,9 @@ void main() {

    setUp(() {
      restarts = 0;
+
+      // Intebtionally unwaited.


Suggested change

// Intebtionally unwaited.

// Intentionally unwaited.

same about the setup could instead be async

CoderDake · 2022-10-31T17:29:26Z

packages/devtools_app/test/vm_developer/object_inspector/vm_developer_common_widgets_test.dart

@@ -38,6 +38,8 @@ void main() {
    when(mockClassObject.reachableSize).thenReturn(null);
    when(mockClassObject.retainedSize).thenReturn(null);

+    // Intebtionally unwaited.


Suggested change

// Intebtionally unwaited.

// Intentionally unwaited.

you could make setup async instead
setUp(() async {

CoderDake · 2022-10-31T17:29:58Z

packages/devtools_app/test/vm_developer/object_inspector/vm_developer_common_widgets_test.dart

    when(mockClassObject.requestRetainingPath()).thenAnswer((_) async {
      retainingPathNotifier.value = testRetainingPath;
    });

    when(mockClassObject.inboundReferences).thenReturn(inboundRefsNotifier);

+    // Intebtionally unwaited.


Suggested change

// Intebtionally unwaited.

// Intentionally unwaited.

polina-c added 4 commits October 28, 2022 14:42

-

f79a120

-

7879fec

Merge branch 'master' of github.com:flutter/devtools into lint

0905308

-

82a2afe

polina-c requested review from elliette, bkonyi, kenzieschmoll, CoderDake and a team as code owners October 28, 2022 23:57

polina-c mentioned this pull request Oct 29, 2022

Sometimes lint discarded_futures does not recognize unawaited. dart-lang/sdk#58911

Closed

-

3917c68

polina-c changed the title ~~Add lint discarded_features.~~ Add lint 'discarded_features'. Oct 29, 2022

polina-c added 4 commits October 29, 2022 12:01

-

3551e64

-

129ea3e

-

cabfb7d

Update program_explorer_test.dart

89cb2de

polina-c changed the title ~~Add lint 'discarded_features'.~~ Add lint 'discarded_futures'. Oct 31, 2022

kenzieschmoll reviewed Oct 31, 2022

View reviewed changes

packages/devtools_app/test/shared/service_extension_widgets_test.dart Outdated Show resolved Hide resolved

kenzieschmoll reviewed Oct 31, 2022

View reviewed changes

CoderDake reviewed Oct 31, 2022

View reviewed changes

-

e0d7500

polina-c mentioned this pull request Oct 31, 2022

Review unawaited futures and await ones that should be awaited. #4668

Open

CoderDake approved these changes Oct 31, 2022

View reviewed changes

kenzieschmoll approved these changes Oct 31, 2022

View reviewed changes

polina-c merged commit b3eefe3 into flutter:master Oct 31, 2022

polina-c deleted the lint branch October 31, 2022 18:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add lint 'discarded_futures'. #4659

Add lint 'discarded_futures'. #4659

polina-c commented Oct 28, 2022

kenzieschmoll Oct 31, 2022

polina-c Oct 31, 2022

CoderDake Oct 31, 2022

polina-c Oct 31, 2022

CoderDake Oct 31, 2022

CoderDake Oct 31, 2022

CoderDake Oct 31, 2022

CoderDake Oct 31, 2022

CoderDake Oct 31, 2022

CoderDake Oct 31, 2022

CoderDake Oct 31, 2022

CoderDake Oct 31, 2022

CoderDake Oct 31, 2022

CoderDake Oct 31, 2022

CoderDake Oct 31, 2022

CoderDake Oct 31, 2022

	onTapLink: (_, href, __) =>
	onTapLink: (_, href, __) async =>
	launchUrl(href!, context),

	actionInProgress ? null : (str) => unawaited(_connect()),
	actionInProgress ? null : (str) async => _connect(),

	onPressed: () => unawaited(_importFile(context)),
	onPressed: () async => _importFile(context),

	onTap: () => unawaited(_onStackFrameSelected(frame)),
	onTap: () async => _onStackFrameSelected(frame),

	canPaste(delegate) ? () => unawaited(handlePaste(delegate)) : null,
	canPaste(delegate) ? () => unawaited(handlePaste(delegate)) : null,

	setUpAll(() async => await loadFonts());
	setUpAll(() async => loadFonts());

Add lint 'discarded_futures'. #4659

Add lint 'discarded_futures'. #4659

Conversation

polina-c commented Oct 28, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment