-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add navigation support to the object inspector #5206
Conversation
Allows for navigating back/forward using the browser's back/forward buttons. This change also updates DevToolsRouterDelegate to keep track of its own navigation history, allowing for history navigation for non-browser targets in the future.
...ges/devtools_app/lib/src/screens/vm_developer/object_inspector/class_hierarchy_explorer.dart
Outdated
Show resolved
Hide resolved
I checked with @bkonyi and confirmed that this is still on their radar. |
Picking this back up, but there's been some regressions in the router behavior that need to be resolved before this change can be verified and made ready to land (see flutter/flutter#130433). |
Strange router behavior reported in flutter/flutter#130433 has been fixed and was able to verify this change works correctly in Chrome. @kenzieschmoll, this is ready for another review. |
I checked with @bkonyi and confirmed that this is still on their radar as of September 20th. |
(triage) I spoke to @bkonyi and he says this is still on his radar ... eventually. |
(triage): Spoke to @bkonyi last week and he promised to get back to this before he retires. |
(triage): @bkonyi said last week the previous statement is still true. |
(triage): @bkonyi assured me that he still hasn't retired. |
Realistically, I'm not going to get back to this. And no, I'm not retiring... yet. |
Allows for navigating back/forward using the browser's back/forward buttons.
This change also updates DevToolsRouterDelegate to keep track of its own navigation history, allowing for history navigation for non-browser targets in the future.
RELEASE_NOTE_EXCEPTION=VM developer mode feature