Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete unreachable default clauses. #8246

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Delete unreachable default clauses. #8246

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions packages/devtools_app/lib/src/screens/app_size/app_size_controller.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ enum DiffTreeType {
case DiffTreeType.decreaseOnly:
return 'Decrease Only';
case DiffTreeType.combined:
default:
return 'Combined';
}
}
Expand All @@ -55,7 +54,6 @@ enum AppUnit {
case AppUnit.mainOnly:
return _mainNodeName;
case AppUnit.entireApp:
default:
return _entireAppNodeName;
}
}
Expand Down Expand Up @@ -185,7 +183,6 @@ class AppSizeController {
case AppUnit.deferredOnly:
return _deferredDiffTreeMap;
case AppUnit.entireApp:
default:
return _diffTreeMap;
}
}
Expand All @@ -205,8 +202,6 @@ class AppSizeController {
return diffMap.decreaseOnly;
case DiffTreeType.combined:
return diffMap.combined;
default:
return diffMap.combined;
}
}

Expand All @@ -221,7 +216,6 @@ class AppSizeController {
case AppUnit.mainOnly:
return _mainOnly;
case AppUnit.entireApp:
default:
return _entireApp;
}
}
Expand Down
1 change: 0 additions & 1 deletion packages/devtools_app/lib/src/screens/inspector/layout_explorer/flex/utils.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,6 @@ extension AxisExtension on Axis {
case Axis.horizontal:
return 'Row';
case Axis.vertical:
default:
return 'Column';
}
}
Expand Down
1 change: 0 additions & 1 deletion packages/devtools_app/lib/src/screens/inspector_v2/layout_explorer/flex/utils.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,6 @@ extension AxisExtension on Axis {
case Axis.horizontal:
return 'Row';
case Axis.vertical:
default:
return 'Column';
}
}
Expand Down
4 changes: 0 additions & 4 deletions packages/devtools_app/lib/src/shared/charts/chart.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -698,10 +698,6 @@ class ChartPainter extends CustomPainter {
);
canvas.drawPath(path, paintFirst);
break;
default:
final message = 'Unknown symbol ${characteristics.symbol}';
assert(false, message);
_log.shout(message);
}
}

Expand Down
2 changes: 0 additions & 2 deletions packages/devtools_app/lib/src/shared/charts/treemap.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,8 +123,6 @@ class _TreemapState extends State<Treemap> {
}
}
return pivotIndex;
default:
return -1;
}
}

Expand Down
1 change: 0 additions & 1 deletion packages/devtools_app/lib/src/shared/primitives/utils.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -518,7 +518,6 @@ class TimeRange {
case TimeUnit.microseconds:
return '[${_start?.inMicroseconds} μs - ${end?.inMicroseconds} μs]';
case TimeUnit.milliseconds:
default:
return '[${_start?.inMilliseconds} ms - ${end?.inMilliseconds} ms]';
}
}
Expand Down
1 change: 0 additions & 1 deletion packages/devtools_app/lib/src/shared/table/_table_row.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,7 +365,6 @@ class _TableRowState<T> extends State<TableRow<T>>
case ColumnAlignment.right:
return Alignment.centerRight;
case ColumnAlignment.left:
default:
return Alignment.centerLeft;
}
}
Expand Down
2 changes: 0 additions & 2 deletions packages/devtools_app/lib/src/shared/table/table_data.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,6 @@ extension ColumnDataExtension<T> on ColumnData<T> {
case ColumnAlignment.right:
return MainAxisAlignment.end;
case ColumnAlignment.left:
default:
return MainAxisAlignment.start;
}
}
Expand All @@ -187,7 +186,6 @@ extension ColumnDataExtension<T> on ColumnData<T> {
case ColumnAlignment.right:
return TextAlign.right;
case ColumnAlignment.left:
default:
return TextAlign.left;
}
}
Expand Down
Loading