Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hot reload button and support service registration. #90

Merged
merged 7 commits into from
Jan 7, 2019
Merged

Add hot reload button and support service registration. #90

merged 7 commits into from
Jan 7, 2019

Conversation

kenzieschmoll
Copy link
Member

Uses the existing 'reloadSources' service in flutter_tools. Will implement hot restart in a later CL.

Piggy backs off of @jacob314 's demo.

jacob314
jacob314 reviewed Jan 4, 2019
View reviewed changes
lib/service_manager.dart Outdated Show resolved Hide resolved
jacob314
jacob314 reviewed Jan 4, 2019
View reviewed changes
lib/service_manager.dart Outdated Show resolved Hide resolved
@kenzieschmoll kenzieschmoll requested a review from jacob314 January 4, 2019 23:23
jacob314
jacob314 reviewed Jan 4, 2019
View reviewed changes
lib/ui/ui_utils.dart Outdated Show resolved Hide resolved
jacob314
jacob314 reviewed Jan 4, 2019
View reviewed changes
lib/ui/ui_utils.dart Outdated Show resolved Hide resolved
jacob314
jacob314 reviewed Jan 4, 2019
View reviewed changes
lib/service_manager.dart Outdated Show resolved Hide resolved
jacob314
jacob314 reviewed Jan 5, 2019
View reviewed changes
lib/service_manager.dart Outdated Show resolved Hide resolved
jacob314
jacob314 approved these changes Jan 5, 2019
View reviewed changes
Copy link
Contributor

@jacob314 jacob314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved with tips on how to make the tests shorter but still as effective.

devoncarew
devoncarew reviewed Jan 5, 2019
View reviewed changes
lib/service_manager.dart
@@ -102,6 +138,17 @@ class ServiceConnectionManager {
_stateController.add(null);
_connectionClosedController.add(null);
}

// TODO(kenzie): add hot restart method, register method in flutter_tools.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aam would be a good one to coordinate with here

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw @aam helpe me figure out how to call this service extension from the devtools web app.

lib/service_manager.dart Show resolved Hide resolved
lib/ui/ui_utils.dart Show resolved Hide resolved
jacob314
jacob314 reviewed Jan 7, 2019
View reviewed changes
lib/service_manager.dart Outdated Show resolved Hide resolved
@kenzieschmoll kenzieschmoll merged commit e22dbec into flutter:master Jan 7, 2019
@kenzieschmoll kenzieschmoll deleted the hotRestartButton branch January 7, 2019 21:19
@kenzieschmoll kenzieschmoll mentioned this pull request Dec 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devoncarew devoncarew devoncarew left review comments

@jacob314 jacob314 jacob314 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kenzieschmoll @jacob314 @devoncarew