omit href when not present

flutter · May 31, 2024 · 2b7967a · 2b7967a
1 parent 648ced6
commit 2b7967a
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/lib/web_ui/lib/src/engine/semantics/link.dart b/lib/web_ui/lib/src/engine/semantics/link.dart
@@ -24,8 +24,9 @@ class Link extends PrimaryRoleManager {
   @override
   DomElement createElement() {
     final DomElement element = domDocument.createElement('a');
-    // TODO: The <a> element has `aria-label={value}`. We should stop that!
-    element.setAttribute('href', semanticsObject.hasValue ? semanticsObject.value! : '#');
+    if (semanticsObject.hasValue) {
+      element.setAttribute('href', semanticsObject.value!);
+    }
     element.style.display = 'block';
     return element;
   }