Skip to content
This repository has been archived by the owner on Feb 25, 2025. It is now read-only.

Commit

Permalink
[fuchsia] Wire through the tzdata-icu capability (#48907)
Browse files Browse the repository at this point in the history
The `tzdata-icu` capability is a directory containing
ICU time zone resource files. These are requried for
correct computation of local times.

Issue: flutter/flutter#139952

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.
  • Loading branch information
filmil authored Jan 18, 2024
1 parent 3f3eb0d commit 9dded18
Show file tree
Hide file tree
Showing 6 changed files with 42 additions and 2 deletions.
10 changes: 9 additions & 1 deletion shell/platform/fuchsia/dart_runner/meta/common.shard.cml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
},
],
use: [
// This is used by the Dart VM to communicate from Dart code to C++ code.
// This is used by the Dart VM to communicate from Dart code to C++ code.
{
storage: "tmp",
path: "/tmp",
Expand All @@ -24,6 +24,14 @@
rights: [ "r*" ],
path: "/config/data",
},
// The ICU time zone data, factored out of `config-data`.
// See:
// https://fuchsia.dev/fuchsia-src/concepts/process/namespaces?typical_directory_structure
{
directory: "tzdata-icu",
rights: [ "r*" ],
path: "/config/tzdata/icu",
},
{
protocol: [
"fuchsia.device.NameProvider", // For fdio uname()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,12 @@
from: "framework",
to: "#realm_builder",
},
// See common.shard.cml.
{
directory: "tzdata-icu",
from: "framework",
to: "#realm_builder",
},
],
// TODO(https://fxbug.dev/114584): Figure out how to bring these in as deps (if possible oot).
facets: {
Expand Down
10 changes: 9 additions & 1 deletion shell/platform/fuchsia/flutter/meta/common.shard.cml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
},
],
use: [
// This is used by the Dart VM to communicate from Dart code to C++ code.
// This is used by the Dart VM to communicate from Dart code to C++ code.
{
storage: "tmp",
path: "/tmp",
Expand All @@ -24,6 +24,14 @@
rights: [ "r*" ],
path: "/config/data",
},
// The ICU time zone data, factored out of `config-data`.
// See:
// https://fuchsia.dev/fuchsia-src/concepts/process/namespaces?typical_directory_structure
{
directory: "tzdata-icu",
rights: [ "r*" ],
path: "/config/tzdata/icu",
},
{
directory: "root-ssl-certificates",
rights: [ "r*" ],
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,12 @@
rights: [ "r*" ],
path: "/config/data",
},
// See common.shard.cml.
{
directory: "tzdata-icu",
rights: [ "r*" ],
path: "/config/tzdata/icu",
},
],
expose: [
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,12 @@
from: "framework",
to: "#realm_builder",
},
// See common.shard.cml.
{
directory: "tzdata-icu",
from: "framework",
to: "#realm_builder",
},
],
// TODO(https://fxbug.dev/114584): Figure out how to bring these in as deps (if possible oot).
facets: {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,12 @@
from: "framework",
to: "#realm_builder",
},
// See common.shard.cml.
{
directory: "tzdata-icu",
from: "framework",
to: "#realm_builder",
},
],
// TODO(https://fxbug.dev/114584): Figure out how to bring these in as deps (if possible oot).
facets: {
Expand Down

0 comments on commit 9dded18

Please sign in to comment.