Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit

Permalink
[embedder] Consistent naming for GL/Metal tests
Browse files Browse the repository at this point in the history
While I've sent a patch to mark the shell/platform/embedder/tests and
fixtures directories as test exempt (since they are tests), by
convention, tests should end in _unittests.* for C++ tests, and _test.*
for Dart tests. This renames for consistency with other tests such as
embedder_a11y_unittests.cc.

Uncovered by #38133

Related: flutter/cocoon#2340
Issue: flutter/flutter#116381
  • Loading branch information
cbracken committed Dec 8, 2022
1 parent 8a113d3 commit ab2563e
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions shell/platform/embedder/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -317,11 +317,11 @@ if (enable_unittests) {
deps = [ ":embedder_unittests_library" ]

if (test_enable_gl) {
sources += [ "tests/embedder_unittests_gl.cc" ]
sources += [ "tests/embedder_gl_unittests.cc" ]
}

if (test_enable_metal) {
sources += [ "tests/embedder_unittests_metal.mm" ]
sources += [ "tests/embedder_metal_unittests.mm" ]
}
}

Expand Down

0 comments on commit ab2563e

Please sign in to comment.