Skip to content

Commit

Permalink
Reverts "[Impeller] Enable depth buffer clipping & Stencil-then-Cover…
Browse files Browse the repository at this point in the history
… path rendering. (#51209)" (#51217)

Reverts #51209
Initiated by: bdero
Reason for reverting: Golden breakages on [engine roll](flutter/flutter#144647) https://flutter-gold.skia.org/search?issue=144647&crs=github&patchsets=5&corpus=flutter
Original PR Author: bdero

Reviewed By: {jonahwilliams, chinmaygarde}

This change reverts the following previous change:
Original Description:
Turn the page, wash your hands.

Addresses the following issues:
* flutter/flutter#143077
* flutter/flutter#137714
* flutter/flutter#138460
* flutter/flutter#123671
* flutter/flutter#141961
* flutter/flutter#134432

Previous attempt:
- #50856
    - reverted with #51191
    - fixed with #51198
  • Loading branch information
auto-submit[bot] authored Mar 5, 2024
1 parent 9e813c7 commit effcf97
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion impeller/entity/contents/content_context.h
Original file line number Diff line number Diff line change
Expand Up @@ -408,7 +408,7 @@ class ContentContext {
///
// TODO(bdero): Remove this setting once StC is fully de-risked
// https://github.com/flutter/flutter/issues/123671
static constexpr bool kEnableStencilThenCover = true;
static constexpr bool kEnableStencilThenCover = false;

#if IMPELLER_ENABLE_3D
std::shared_ptr<scene::SceneContext> GetSceneContext() const;
Expand Down

0 comments on commit effcf97

Please sign in to comment.