Add suggested Java changes from flutter roll #10176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -490,6 +490,7 @@ public void onPostResume() { | |||
| protected void onNewIntent(@NonNull Intent intent) { | |||
| // Forward Intents to our FlutterFragment in case it cares. | |||
| flutterFragment.onNewIntent(intent); | |||
| super.onNewIntent(intent); | |||
There was a problem hiding this comment.
I don't think this requirement is correct. The docs don't say that the super call through is required, and the implementation here is a no-op:
https://android.googlesource.com/platform/frameworks/base/+/android-2.3.5_r1/core/java/android/app/Activity.java#1025
I'd like to avoid calling super in cases where it doesn't do anything.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 27, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Jul 27, 2019
flutter/engine@3e0cff2...bb2e7a6 git log 3e0cff2..bb2e7a6 --no-merges --oneline bb2e7a6 Roll src/third_party/skia 14963cef70cc..ff5d7a2f9033 (4 commits) (flutter/engine#10193) 6b2157f Roll fuchsia/sdk/core/linux-amd64 from 4UIZFD0vdZLUDS9k1fP7RRJ1GV48wRQ7-yqjkKVbDvcC to TA0dEf--c1b-EPkEzP27uqiCqVM2Noh-cOraEoXG-kMC (flutter/engine#10190) 69e0800 [fuchsia] Artifacts now contain gen_snapshot and gen_snapshot_product (flutter/engine#10188) 358c729 Roll fuchsia/sdk/core/mac-amd64 from sygT6NTtnUPSogR7MOMaqVm49W_8wi57rIJpNpOJ-jQC to 2EmJ-Ug89PGpagl0Me9qokZqsT61PSvUfuZasACGK5AC (flutter/engine#10187) aea0d7a test scenario_app on CI (flutter/engine#10065) 6752461 Add better CIPD docs. (flutter/engine#10185) f33b2d4 Uncommemt publish to CIPD (flutter/engine#10183) e10a19f Roll src/third_party/skia 66ed6a0cad6d..14963cef70cc (9 commits) (flutter/engine#10181) e1ab0fc Roll src/third_party/dart 86dba81dec..0ca1582afd (2 commits) (flutter/engine#10160) 3e3efe4 [dart_runner] dart jit runner and dart jit product runner (flutter/engine#10179) 4b587a6 Roll fuchsia/sdk/core/linux-amd64 from tKTQX9s1EPV7nn9f81lwxk2xIr3wL220KA6BGv-sceMC to 4UIZFD0vdZLUDS9k1fP7RRJ1GV48wRQ7-yqjkKVbDvcC (flutter/engine#10180) be9b245 add suggested changes from flutter roll (flutter/engine#10176) 318c8c5 Roll fuchsia/sdk/core/mac-amd64 from SjR5fqBfe7qxjHNWDZx6381UbPUcw78mDI9dFAIN-Y4C to sygT6NTtnUPSogR7MOMaqVm49W_8wi57rIJpNpOJ-jQC (flutter/engine#10177) a4778ea Removed unnecessary call to find the App.framework. (flutter/engine#10178) 2dc03ab Added integration test that tests that the first frame callback is called (flutter/engine#10145) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff ([email protected]), and stop the roller if necessary.
johnsonmh
pushed a commit
to johnsonmh/flutter
that referenced
this pull request
Jul 30, 2019
flutter/engine@3e0cff2...bb2e7a6 git log 3e0cff2..bb2e7a6 --no-merges --oneline bb2e7a6 Roll src/third_party/skia 14963cef70cc..ff5d7a2f9033 (4 commits) (flutter/engine#10193) 6b2157f Roll fuchsia/sdk/core/linux-amd64 from 4UIZFD0vdZLUDS9k1fP7RRJ1GV48wRQ7-yqjkKVbDvcC to TA0dEf--c1b-EPkEzP27uqiCqVM2Noh-cOraEoXG-kMC (flutter/engine#10190) 69e0800 [fuchsia] Artifacts now contain gen_snapshot and gen_snapshot_product (flutter/engine#10188) 358c729 Roll fuchsia/sdk/core/mac-amd64 from sygT6NTtnUPSogR7MOMaqVm49W_8wi57rIJpNpOJ-jQC to 2EmJ-Ug89PGpagl0Me9qokZqsT61PSvUfuZasACGK5AC (flutter/engine#10187) aea0d7a test scenario_app on CI (flutter/engine#10065) 6752461 Add better CIPD docs. (flutter/engine#10185) f33b2d4 Uncommemt publish to CIPD (flutter/engine#10183) e10a19f Roll src/third_party/skia 66ed6a0cad6d..14963cef70cc (9 commits) (flutter/engine#10181) e1ab0fc Roll src/third_party/dart 86dba81dec..0ca1582afd (2 commits) (flutter/engine#10160) 3e3efe4 [dart_runner] dart jit runner and dart jit product runner (flutter/engine#10179) 4b587a6 Roll fuchsia/sdk/core/linux-amd64 from tKTQX9s1EPV7nn9f81lwxk2xIr3wL220KA6BGv-sceMC to 4UIZFD0vdZLUDS9k1fP7RRJ1GV48wRQ7-yqjkKVbDvcC (flutter/engine#10180) be9b245 add suggested changes from flutter roll (flutter/engine#10176) 318c8c5 Roll fuchsia/sdk/core/mac-amd64 from SjR5fqBfe7qxjHNWDZx6381UbPUcw78mDI9dFAIN-Y4C to sygT6NTtnUPSogR7MOMaqVm49W_8wi57rIJpNpOJ-jQC (flutter/engine#10177) a4778ea Removed unnecessary call to find the App.framework. (flutter/engine#10178) 2dc03ab Added integration test that tests that the first frame callback is called (flutter/engine#10145) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff ([email protected]), and stop the roller if necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These issues were flagged during the google3 roll:
2x unused imports
1x missing super call on mustCallSuper method.