Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add better CIPD docs. #10185

Merged
merged 1 commit into from
Jul 26, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions shell/platform/android/test/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -55,11 +55,14 @@ runtime, but not compile time. If so you'll just need to update

See the Chromium instructions on ["Updating a CIPD
dependency"](https://chromium.googlesource.com/chromium/src/+/master/docs/cipd.md#Updating-a-CIPD-dependency)
for how to upload a package update to CIPD.

Once you've done that, also make sure to tag the new package version with the
updated timestamp and robolectric version (most likely still 3.8, unless you've
migrated all the packges to 4+).
for how to upload a package update to CIPD. Download and extract the latest
package from CIPD and then copy
[shell/platform/android/test/cipd.yaml](cipd.yaml) into the extracted directory
to use as the base for the pre-existing package. Add new dependencies to `lib/`.

Once you've uploaded the new version, also make sure to tag it with the updated
timestamp and robolectric version (most likely still 3.8, unless you've migrated
all the packges to 4+).

$ cipd set-tag --version=<new_version_hash> -tag "last_updated:<timestamp>"
$ cipd set-tag --version=<new_version_hash> -tag "robolectric_version:<robolectric_version>"
Expand Down
4 changes: 4 additions & 0 deletions shell/platform/android/test/cipd.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
package: flutter/android/robolectric_bundle
description: Robolectric 3.8 and associated runtime dependencies.
data:
- dir: lib