Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export FFI from sky_engine. #10282

Merged
merged 1 commit into from
Jul 31, 2019
Merged

Export FFI from sky_engine. #10282

merged 1 commit into from
Jul 31, 2019

Conversation

sjindel-google
Copy link
Contributor

@sjindel-google sjindel-google commented Jul 31, 2019

This makes "dart:ffi" visible to the analysis server. Tested locally with VSCode.

Fixes dart-lang/sdk#37141.

@sjindel-google sjindel-google merged commit 7df7b51 into master Jul 31, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 31, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 1, 2019
engine-flutter-autoroll added a commit to flutter/flutter that referenced this pull request Aug 1, 2019
[email protected]:flutter/engine.git/compare/a29ef660134f...59ac63d

git log a29ef66..59ac63d --no-merges --oneline
2019-07-31 [email protected] Ensure that the SingleFrameCodec stays alive until the ImageDecoder invokes its callback (flutter/engine#10297)
2019-07-31 [email protected] [glfw] Enables replies on binary messenger in glfw embedder (flutter/engine#9948)
2019-07-31 [email protected] Roll fuchsia/sdk/core/mac-amd64 from fuchsia/sdk/core/mac-amd64:TAkpmqxKgauDvmpeaOTOAbYsnz1nWuqznTirppN0dGoC to fuchsia/sdk/core/mac-amd64:bswmziOk2a7sku7aG0fnZO7sQOFPK_XBy58QPcqsugwC (flutter/engine#10300)
2019-07-31 [email protected] Roll src/third_party/skia c876404e64d2..83d8a949ae22 (6 commits) (flutter/engine#10302)
2019-07-31 [email protected] Fix run.start -> run_start (flutter/engine#10295)
2019-07-31 [email protected] Roll fuchsia/sdk/core/linux-amd64 from fuchsia/sdk/core/linux-amd64:E8lhQA7KKqhzZkfqaF8zKnqOMy88-Z3lf4uBnUNHa4AC to fuchsia/sdk/core/linux-amd64:2k-0epsqEV14oZvIxpS-jHkPhZa837aSNjEj14wd73MC (flutter/engine#10301)
2019-07-31 [email protected] Make tree green for real this time, I promise. (flutter/engine#10303)
2019-07-31 [email protected] Fix red build again (flutter/engine#10298)
2019-07-31 [email protected] Roll src/third_party/dart 80c4954d4d..bd049f5b53 (37 commits) (flutter/engine#10294)
2019-07-31 [email protected] fix CI (flutter/engine#10296)
2019-07-31 [email protected] [fuchsia] Make cirrus build fuchsia artifacts (flutter/engine#10268)
2019-07-31 [email protected] Add fuchsia.stamp for roller (flutter/engine#10293)
2019-07-31 [email protected]  [macos] Reland function refactor (flutter/engine#10189)
2019-07-31 [email protected] Export FFI from sky_engine. (flutter/engine#10282)
2019-07-31 [email protected] Roll src/third_party/skia 6808e2d1faac..c876404e64d2 (6 commits) (flutter/engine#10292)
2019-07-31 [email protected] Roll fuchsia/sdk/core/mac-amd64 from fuchsia/sdk/core/mac-amd64:A4Ah4g0K30dWnbolQ7Z3zyXapbAyy3d9l4IeLGAG9YQC to fuchsia/sdk/core/mac-amd64:TAkpmqxKgauDvmpeaOTOAbYsnz1nWuqznTirppN0dGoC (flutter/engine#10291)
2019-07-31 [email protected] Roll fuchsia/sdk/core/linux-amd64 from fuchsia/sdk/core/linux-amd64:6j9WXOOtqKZzSKIgQi-12GJ1MYzPDJvq-RLAtpJpGB0C to fuchsia/sdk/core/linux-amd64:E8lhQA7KKqhzZkfqaF8zKnqOMy88-Z3lf4uBnUNHa4AC (flutter/engine#10290)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff ([email protected]), and stop
the roller if necessary.
@dnfield dnfield deleted the vscode branch August 15, 2019 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VSCode doesn't pick up 'dart:ffi' imports
3 participants