Use Fuchsia trace macros when targeting Fuchsia SDK #10634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When |OS_FUCHSIA| is defined (even when |FUCHSIA_SDK| is defined as well), use the Fuchsia SDK trace macros rather than the Dart timeline. Reasons for doing this include: Fuchsia's trace macros support categories. This allows one to distinguish between (e.g.) "flutter" and "skia" trace events for trace recording and trace visualization. Fuchsia has existing in tree benchmarks that depend on finding certain events under category "flutter". See the Fuchsia performance mailing list discussion for more context.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 6, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Aug 6, 2019
[email protected]:flutter/engine.git/compare/2ccfd9e562c9...a665c6f git log 2ccfd9e..a665c6f --no-merges --oneline 2019-08-06 [email protected] Roll fuchsia/sdk/core/mac-amd64 from QdP5I... to C9SBX... (flutter/engine#10649) 2019-08-06 [email protected] Roll fuchsia/sdk/core/linux-amd64 from siBGl... to Gh0U-... (flutter/engine#10648) 2019-08-06 [email protected] Roll fuchsia/sdk/core/mac-amd64 from Nj2Qs... to QdP5I... (flutter/engine#10647) 2019-08-06 [email protected] reset platformViewsController in engine.destroyContext when allowHeadlessExecution = false (flutter/engine#10629) 2019-08-05 [email protected] [flutter_runner] Port: Add connectToService, wrapping fdio_ns_connect. (flutter/engine#10644) 2019-08-05 [email protected] Don't use DBC for hot-reload on iOS. (flutter/engine#10645) 2019-08-05 [email protected] Ensure debug-mode apps are always attached on iOS. (flutter/engine#10186) 2019-08-05 [email protected] Capture stderr for ninja command (flutter/engine#9896) 2019-08-05 [email protected] Roll src/third_party/skia 4df3d5340ef3..eb0770211a6c (13 commits) (flutter/engine#10643) 2019-08-05 [email protected] Roll src/third_party/dart 4bebfebdbc..8cd01287b4 (30 commits) (flutter/engine#10642) 2019-08-05 [email protected] Roll fuchsia/sdk/core/linux-amd64 from 3hQdw... to siBGl... (flutter/engine#10640) 2019-08-05 [email protected] Roll fuchsia/sdk/core/mac-amd64 from yvc6m... to Nj2Qs... (flutter/engine#10638) 2019-08-05 [email protected] Document the thread test fixture. (flutter/engine#10637) 2019-08-05 [email protected] Use Fuchsia trace macros when targeting Fuchsia SDK (flutter/engine#10634) 2019-08-05 [email protected] Fix threading and re-enable resource cache shell unit-tests. (flutter/engine#10636) 2019-08-05 [email protected] [fuchsia] CloneChannelFromFD fix for system.cc (flutter/engine#10635) 2019-08-05 [email protected] Roll src/third_party/skia a800ec96f724..4df3d5340ef3 (20 commits) (flutter/engine#10632) 2019-08-05 [email protected] Roll src/third_party/dart 9bb446aae1...4bebfebdbc (7 commits). (flutter/engine#10484) 2019-08-05 [email protected] Roll fuchsia/sdk/core/linux-amd64 from qTyU_... to 3hQdw... (flutter/engine#10627) 2019-08-05 [email protected] Roll fuchsia/sdk/core/mac-amd64 from cvvjU... to yvc6m... (flutter/engine#10626) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff ([email protected]), and stop the roller if necessary.
cfontas
pushed a commit
to cfontas/engine
that referenced
this pull request
Aug 8, 2019
When |OS_FUCHSIA| is defined (even when |FUCHSIA_SDK| is defined as well), use the Fuchsia SDK trace macros rather than the Dart timeline. Reasons for doing this include: Fuchsia's trace macros support categories. This allows one to distinguish between (e.g.) "flutter" and "skia" trace events for trace recording and trace visualization. Fuchsia has existing in tree benchmarks that depend on finding certain events under category "flutter". See the Fuchsia performance mailing list discussion for more context.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When |OS_FUCHSIA| is defined (even when |FUCHSIA_SDK| is defined as
well), use the Fuchsia SDK trace macros rather than the Dart timeline.
Reasons for doing this include:
Fuchsia's trace macros support categories. This allows one to
distinguish between (e.g.) "flutter" and "skia" trace events for trace
recording and trace visualization.
Fuchsia has existing in tree benchmarks that depend on finding certain
events under category "flutter".
See the Fuchsia performance mailing list discussion for more context.