-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rolls engine to Android SDK 29 and its corresponding tools #10692
Conversation
We need to land flutter/buildroot#294 so you can roll to that in this patch; my attempted fix last night didn't end up working, so rolling to the current ToT will break Windows again. |
Looks like Javadoc is failing on this - does it pass locally? |
@dnfield I also just noticed -- I forgot to make changes to two files from |
I just made the changes, but we still need to wait for flutter/buildroot#294 to land and then roll the buildroot to that patch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I think this is a better way to land it anyway, so that we can identify regressions independent of other changes. Thanks for doing this.
DEPS
Outdated
@@ -137,7 +137,7 @@ allowed_hosts = [ | |||
] | |||
|
|||
deps = { | |||
'src': 'https://github.com/flutter/buildroot.git' + '@' + 'c6bd1f1e25048a97d99cf2fa679bd54ebad94697', | |||
'src': 'https://github.com/flutter/buildroot.git' + '@' + '07d0e2668a491a67197d569d4e6a724d3191bdd1', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[email protected]:flutter/engine.git/compare/dac86eb7fbf7...81f695f git log dac86eb..81f695f --no-merges --oneline 2019-08-07 [email protected] Roll src/third_party/dart f3139f57b4..f29f41f1a5 (3 commits) (flutter/engine#10693) 2019-08-07 [email protected] Roll buildroot forward to unbreak ToT (flutter/engine#10694) 2019-08-07 [email protected] Rolls engine to Android SDK 29 and its corresponding tools (flutter/engine#10692) 2019-08-07 [email protected] Fix empty composing range on iOS (flutter/engine#10381) 2019-08-07 [email protected] Roll src/third_party/skia ed19e97294f6..593290ed75fd (2 commits) (flutter/engine#10691) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff ([email protected]), and stop the roller if necessary.
…0692) * Rolls engine to Android SDK 29 and its corresponding tools * Update from android-28 to android-29 in relevant files * Roll buildroot to tip of tree
Updates the engine's Android SDK and tool versions to the buildroot's latest version. This unblocks the buildroot roll by updating the engine's Android SDK and related tools, since it may take some time before #10413 lands.
For all associated CIPD changes, see https://chrome-infra-packages.appspot.com/p/flutter/android/sdk