Remove use of the deprecated AccessibilityNodeInfo boundsInParent API #10773
Conversation
There was a problem hiding this comment.
LGTM
What is the alternative?
getBoundsInScreen, looks like we're already using it below. https://developer.android.com/reference/android/view/accessibility/AccessibilityNodeInfo#getBoundsInParent(android.graphics.Rect)
[email protected]:flutter/engine.git/compare/d784a39ab8ce...d9bbe37 git log d784a39..d9bbe37 --no-merges --oneline 2019-08-08 [email protected] Remove use of the deprecated AccessibilityNodeInfo boundsInParent API (flutter/engine#10773) 2019-08-08 [email protected] Manually roll Skia to pull in iOS armv7 build failure fix. (flutter/engine#10777) 2019-08-08 [email protected] Manual roll of Fuchsia clang/linux-amd64 toolchain (flutter/engine#10774) 2019-08-08 [email protected] Roll src/third_party/skia 19e3cd4c9cd5..4acbab33bd40 (6 commits) (flutter/engine#10769) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff ([email protected]), and stop the roller if necessary.
|
This broke webview a11y. We may try to translate boundsInParent to a boundsInScreen, but it scares me a bit, specifically as we'll have to replicate whatever logic Android has to deal with ambiguity between these two. I think the right thing to do here is to keep using the deprecated methods and silence the warnings. |
…rent API (flutter#10773)" This reverts commit d9bbe37.
No description provided.