-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Forwards iOS dark mode trait to the Flutter framework.". #10789
Merged
chinmaygarde
merged 1 commit into
master
from
revert-9722-34441_send_ios_brightness_to_flutter
Aug 9, 2019
Merged
Revert "Forwards iOS dark mode trait to the Flutter framework.". #10789
chinmaygarde
merged 1 commit into
master
from
revert-9722-34441_send_ios_brightness_to_flutter
Aug 9, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnfield
approved these changes
Aug 9, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 9, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 9, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 9, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Aug 9, 2019
[email protected]:flutter/engine.git/compare/d9bbe37ce376...dd735c9 git log d9bbe37..dd735c9 --no-merges --oneline 2019-08-09 [email protected] [flutter_runner] Improve frame scheduling (flutter/engine#10780) 2019-08-09 [email protected] [flutter] Create the compositor context on the GPU task runner. (flutter/engine#10781) 2019-08-09 [email protected] Revert "Forwards iOS dark mode trait to the Flutter framework (#34441). (#9722)" (flutter/engine#10789) 2019-08-08 [email protected] Forwards iOS dark mode trait to the Flutter framework (#34441). (flutter/engine#9722) 2019-08-08 [email protected] Specify which android variant for tests (flutter/engine#10717) 2019-08-08 [email protected] Don't use gradle daemon for building (flutter/engine#10771) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff ([email protected]), and stop the roller if necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #9722 to fix LUCI. This will be re-landed with a preprocessor guard that makes this commit take effect only on iOS 13 SDKs.