Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Forwards iOS dark mode trait to the Flutter framework.". #10789

Merged

Conversation

chinmaygarde
Copy link
Member

Reverts #9722 to fix LUCI. This will be re-landed with a preprocessor guard that makes this commit take effect only on iOS 13 SDKs.

@chinmaygarde chinmaygarde changed the title Revert "Forwards iOS dark mode trait to the Flutter framework (#34441)." Revert "Forwards iOS dark mode trait to the Flutter framework.". Aug 9, 2019
Copy link
Contributor

@dnfield dnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chinmaygarde chinmaygarde merged commit 7cfb3de into master Aug 9, 2019
@chinmaygarde chinmaygarde deleted the revert-9722-34441_send_ios_brightness_to_flutter branch August 9, 2019 00:15
engine-flutter-autoroll added a commit to flutter/flutter that referenced this pull request Aug 9, 2019
[email protected]:flutter/engine.git/compare/d9bbe37ce376...dd735c9

git log d9bbe37..dd735c9 --no-merges --oneline
2019-08-09 [email protected] [flutter_runner] Improve frame scheduling (flutter/engine#10780)
2019-08-09 [email protected] [flutter] Create the compositor context on the GPU task runner. (flutter/engine#10781)
2019-08-09 [email protected] Revert "Forwards iOS dark mode trait to the Flutter framework (#34441). (#9722)" (flutter/engine#10789)
2019-08-08 [email protected] Forwards iOS dark mode trait to the Flutter framework (#34441). (flutter/engine#9722)
2019-08-08 [email protected] Specify which android variant for tests (flutter/engine#10717)
2019-08-08 [email protected] Don't use gradle daemon for building (flutter/engine#10771)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff ([email protected]), and stop
the roller if necessary.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants