Avoid dynamic lookups of the engine library's symbols on Android #11001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dynamic linker on some older versions of Android on x86 fails when doing dlsym(RTLD_DEFAULT) lookups of symbols exported by the engine library itself. The engine needs to do this for some data files that are linked into the engine library (ICU data and Dart snapshot blobs). To work around this, the engine will declare static symbols for these data objects on the affected platforms. Fixes flutter/flutter#20091
chinmaygarde
approved these changes
Aug 14, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 14, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Aug 14, 2019
[email protected]:flutter/engine.git/compare/cdaf44265b74...4f00cb7 git log cdaf442..4f00cb7 --no-merges --oneline 2019-08-14 [email protected] Add script for running ios Tests on simulator (flutter/engine#10999) 2019-08-14 [email protected] Avoid dynamic lookups of the engine library's symbols on Android (flutter/engine#11001) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff ([email protected]), and stop the roller if necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dynamic linker on some older versions of Android on x86 fails when doing
dlsym(RTLD_DEFAULT) lookups of symbols exported by the engine library itself.
The engine needs to do this for some data files that are linked into the engine
library (ICU data and Dart snapshot blobs).
To work around this, the engine will declare static symbols for these data
objects on the affected platforms.
Fixes flutter/flutter#20091