Hide verbose dart snapshot during run_test.py #11040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this flag, a single dart test will print out 306 lines. With this flag, a single dart test will only print out 33 lines. This helps a lot in local tests.
|
If you're interested, see the output with this changethe output without this change |
dnfield
reviewed
Aug 15, 2019
testing/run_tests.py
Outdated
| @@ -281,6 +285,8 @@ def main(): | |||
| parser.add_argument('--android-variant', dest='android_variant', action='store', | |||
| default='android_debug_unopt', | |||
| help='The engine build variant to run java tests for') | |||
| parser.add_argument('--no-verbose', dest='no_verbose', action='store_true', | |||
There was a problem hiding this comment.
nit: instead of --no-verbose, can we call this something like --quiet-dart-snapshot or something? I'd also be ok with defaulting it to True - I've yet to see that output be helpful.
There was a problem hiding this comment.
Or just --verbose (off by default).
There was a problem hiding this comment.
Renamed the flag to --verbose-dart-snapshot so by default (without giving --verbose-dart-snapshot) we won't show those logs.
There was a problem hiding this comment.
...Github didn't load Chinmay's comment while I was replying and modifying the code. I'll merge as is, and probably change the flag name to --verbose in the future if we find more verbose logging that needs to be hidden.
dnfield
approved these changes
Aug 15, 2019
liyuqian
changed the title
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 16, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Aug 16, 2019
[email protected]:flutter/engine.git/compare/f8e7453f1106...4b7a552 git log f8e7453..4b7a552 --no-merges --oneline 2019-08-16 [email protected] Roll Dart back to e35e8833 (flutter/engine#11043) 2019-08-16 [email protected] Roll src/third_party/dart 306f8e04bb..fecc4c8f2d (4 commits) 2019-08-16 [email protected] Roll src/third_party/skia 963a606677e1..6a519b8dd895 (6 commits) (flutter/engine#11042) 2019-08-15 [email protected] Hide verbose dart snapshot during run_test.py (flutter/engine#11040) 2019-08-15 [email protected] Remove ability to override mac_sdk_path in flutter/tools/gn (flutter/engine#11013) 2019-08-15 [email protected] Roll src/third_party/dart cd16fba718..306f8e04bb (10 commits) 2019-08-15 [email protected] Roll buildroot to pick up recent macOS changes (flutter/engine#11037) 2019-08-15 [email protected] Remove the ParagraphImpl class from the text API (flutter/engine#11012) 2019-08-15 [email protected] Disable a deprecation warning for use of a TaskDescription constructor for older platforms (flutter/engine#11029) 2019-08-15 [email protected] Re-lands platform brightness support on iOS, plus platform contrast (flutter/engine#10791) 2019-08-15 [email protected] [fuchsia] Add required trace so files for fuchsia fars (flutter/engine#11036) 2019-08-15 [email protected] Roll src/third_party/skia e5dc1ebc864a..963a606677e1 (14 commits) (flutter/engine#11032) 2019-08-15 [email protected] Add _glfw versions of the GLFW desktop libraries (flutter/engine#11024) 2019-08-15 [email protected] Roll fuchsia/sdk/core/linux-amd64 from _fvZN... to 5Nhwb... (flutter/engine#11028) 2019-08-15 [email protected] Roll src/third_party/dart 9552646dc4..cd16fba718 (5 commits) 2019-08-15 [email protected] Fix first frame logic (flutter/engine#11027) 2019-08-15 [email protected] remove OS version (flutter/engine#11033) 2019-08-15 [email protected] Roll src/third_party/skia e30a485a68c9..e5dc1ebc864a (7 commits) (flutter/engine#11025) 2019-08-15 [email protected] Roll src/third_party/dart cae08c6813..9552646dc4 (3 commits) 2019-08-15 [email protected] Remove the output directory prefix from the Android engine JAR filename (flutter/engine#11015) 2019-08-15 [email protected] Fix flutter/flutter #34791 (flutter/engine#9977) 2019-08-15 [email protected] Roll src/third_party/dart e35e8833ee..cae08c6813 (28 commits) 2019-08-15 [email protected] Roll src/third_party/skia f3f50099533d..e30a485a68c9 (2 commits) (flutter/engine#11022) 2019-08-15 [email protected] Roll src/third_party/skia 319fd3d7bcb4..f3f50099533d (4 commits) (flutter/engine#11021) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff ([email protected]), and stop the roller if necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this change, a single dart test will print out 306 lines.
With this change, a single dart test will only print out 33 lines.
This helps a lot in local tests.
In order to return to the old logging, set
--verbose-dart-snapshotflag.