Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ccls config files to .gitignore #11046

Merged
merged 1 commit into from
Aug 16, 2019
Merged

Conversation

flar
Copy link
Contributor

@flar flar commented Aug 16, 2019

No description provided.

@flar
Copy link
Contributor Author

flar commented Aug 16, 2019

Just to point out the obvious - compile_commands.json is produced in the ../out directory, but you have to copy (or link) it to the root of the project for ccls to see it. Their setup/config recipes include "set up your project and then ln -s /compile_commands.json". Really they should just allow you to set a location for the file in a .ccls config file, but ignoring compile_commands.json in src/flutter seems harmless in the meantime...

Copy link
Contributor

@iskakaushik iskakaushik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flar flar merged commit 942e631 into flutter:master Aug 16, 2019
@flar flar deleted the ccls-config-gitignore branch August 16, 2019 17:49
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 16, 2019
engine-flutter-autoroll added a commit to flutter/flutter that referenced this pull request Aug 17, 2019
[email protected]:flutter/engine.git/compare/e5f9132b347c...4d5c38e

git log e5f9132..4d5c38e --no-merges --oneline
2019-08-16 [email protected] Roll src/third_party/dart a3b579d5c3..2a3b844b41 (5 commits) (flutter/engine#11060)
2019-08-16 [email protected] Roll src/third_party/skia df54f37a5dc1..237a95fe7b28 (2 commits) (flutter/engine#11058)
2019-08-16 [email protected] Roll buildroot to 5a33d6ab to pickup changes to toolchain version tracking. (flutter/engine#11061)
2019-08-16 [email protected] Sort the Skia typefaces in a font style set into a consistent order (flutter/engine#11056)
2019-08-16 [email protected] Add ccls config files to .gitignore (flutter/engine#11046)
2019-08-16 [email protected] Pass Android Q insets.systemGestureInsets to Window (flutter/engine#10413)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff ([email protected]), and stop
the roller if necessary.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants