More updates to the Robolectric test harness #11068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jason-simmons
approved these changes
Aug 16, 2019
Previously the test wasn't correctly re-building the engine when its files changed on multiple runs of `testing/run_tests.py`. It looks like this is because the test build target wasn't depending on the entire engine Android dependency, so some code changes were being ignored. Update the build.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 17, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Aug 17, 2019
[email protected]:flutter/engine.git/compare/4d5c38e215e9...e23a2e2 git log 4d5c38e..e23a2e2 --no-merges --oneline 2019-08-17 [email protected] More updates to the Robolectric test harness (flutter/engine#11068) 2019-08-16 [email protected] Minor update to the Robolectric test harness (flutter/engine#11067) 2019-08-16 [email protected] Roll src/third_party/dart 2a3b844b41..8ab978b6d4 (7 commits) 2019-08-16 [email protected] Roll fuchsia/sdk/core/linux-amd64 from 7b00W... to -UaaS... (flutter/engine#11065) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff ([email protected]), and stop the roller if necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the test wasn't correctly re-building the engine when its
files changed on multiple runs of
testing/run_tests.py. It looks likethis is because the test build target wasn't depending on the entire
engine Android dependency, so some code changes were being ignored.
Update the build.