[dynamic_thread_merging] Resubmit only on the frame where the merge #11075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnfield
approved these changes
Aug 17, 2019
|
Also, we should leave the TODAY bug open until this rolls into the framework. |
|
@dnfield I can create a manual engine -> framework roll to address this. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 18, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Aug 18, 2019
[email protected]:flutter/engine.git/compare/3dc233f04e8e...5540684 git log 3dc233f..5540684 --no-merges --oneline 2019-08-17 [email protected] Roll src/third_party/skia 9318a6cfbcdd..4b567cd679ab (1 commits) (flutter/engine#11077) 2019-08-17 [email protected] [dynamic_thread_merging] Resubmit only on the frame where the merge (flutter/engine#11075) 2019-08-17 [email protected] Roll fuchsia/clang/mac-amd64 from VdFWD... to 4uAyd... (flutter/engine#11074) 2019-08-17 [email protected] Roll src/third_party/skia a0c9d43c2075..9318a6cfbcdd (1 commits) (flutter/engine#11073) 2019-08-17 [email protected] Roll src/third_party/dart beee442625..79e6c74337 (8 commits) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff ([email protected]), and stop the roller if necessary.
amirh
reviewed
Aug 19, 2019
There was a problem hiding this comment.
LGTM
I't s a pity we don't have test coverage for this, though I believe the e2e tests @cyanglaz is putting together should have caught this (flutter/flutter#36648 and #11059)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I switched from boolean to enum to decide when to merge-unmerge the threads.
addresses: flutter/flutter#38735