Update FlutterPlatformViewsTests #23158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 17, 2020 14:44
gaaclarke
approved these changes
Dec 17, 2020
| { | ||
| // ***** Sequence 1, finishing touch event with touchEnded ***** // | ||
|
|
||
| id event = OCMClassMock([UIEvent class]); |
There was a problem hiding this comment.
Why are you sharing these events now? I would have tried to limit the number of variables.
gaaclarke
approved these changes
Dec 18, 2020
cyanglaz
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 18, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 18, 2020
zanderso
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 18, 2020
* c608b07 bump fuchsia toolchain to clang-12 (flutter/engine#23067) * 8a3e9a2 fix crash in FontCollection::init() when FontFamily is empty (flutter/engine#23019) * 95ba5ca Roll Skia from 6f31e27f1e29 to 85fa75616dfe (7 revisions) (flutter/engine#23118) * 50e7d89 [web] Switch web-render option default to auto (flutter/engine#23090) * 8854520 Roll Skia from 85fa75616dfe to d6f2338ab194 (3 revisions) (flutter/engine#23119) * acad21c [web] Tests for rich paragraph DOM (flutter/engine#23097) * 27ebbc4 Rename PointerState.isDown as per style guide (flutter/engine#23120) * 19950f5 [web] Rich paragraph getBoxesForRange (flutter/engine#23098) * 581acbe Roll Skia from d6f2338ab194 to 1d89532d5988 (1 revision) (flutter/engine#23122) * 540b191 Roll Fuchsia Mac SDK from acylwa3i4... to chLTYsKMR... (flutter/engine#23125) * 3b52edf Roll Skia from 1d89532d5988 to 7839f66540b6 (1 revision) (flutter/engine#23126) * 6b25350 Roll Fuchsia Linux SDK from TIKHoiQyP... to wu6yV-_BL... (flutter/engine#23127) * 9c72085 Roll Skia from 7839f66540b6 to 20f1b3462878 (1 revision) (flutter/engine#23129) * ee323d0 Roll Skia from 20f1b3462878 to 995f0366bd21 (2 revisions) (flutter/engine#23132) * 625aa69 Roll Skia from 995f0366bd21 to b64da3907f76 (1 revision) (flutter/engine#23135) * affc421 Roll Skia from b64da3907f76 to 81da68af2ecf (7 revisions) (flutter/engine#23142) * 9a6a31e Roll Fuchsia Mac SDK from chLTYsKMR... to RDUxjnng0... (flutter/engine#23143) * 78657ed Added golden test to make sure that spawn engines work. (flutter/engine#23066) * bb9cac2 Roll Fuchsia Linux SDK from wu6yV-_BL... to _l04etgVd... (flutter/engine#23145) * 51c9ae9 Add --strict_null_safety_checks to the Dart flag allowlist (flutter/engine#23144) * 76310c4 Add missing sdk constriant in pubspec.yaml files. (flutter/engine#23124) * 6e54f0d [fuchsia] Add wrapper for zx_clock_get_monotonic. (flutter/engine#23128) * ade75e0 [web] Rich paragraph getPositionForOffset (flutter/engine#23133) * 2ef2c86 Fix engine in preparation for implementing dart-lang/language#1274 (flutter/engine#23131) * 9384324 Update android_lint deps (flutter/engine#23151) * ea4bb2a Roll Skia from 81da68af2ecf to 7b920446a8fc (14 revisions) (flutter/engine#23152) * 4b5e4e6 Make it easier to turn on Xcode symlinks (flutter/engine#23150) * 325f069 Roll fuchsia toolchain (flutter/engine#23155) * 05704d3 Use include for C/C++ headers in darwin/macos (flutter/engine#23035) * 8d3d69b Turned no malloc scribble and randomized the tests. (flutter/engine#23014) * 418cc48 Fix macOS crash when modifier keys pressed. (flutter/engine#23154) * a8c360d Update FlutterPlatformViewsTests (flutter/engine#23158) * d941aef [web] Rich text painting on bitmap canvas (flutter/engine#23136) * 67cb0f3 Revert "[web] Switch web-render option default to auto (#23090)" (flutter/engine#23161) * c4b48c5 Roll Skia from 7b920446a8fc to dfc880bd9ba0 (14 revisions) (flutter/engine#23164) * de1de9d Disable FlutterPluginAppLifeCycleDelegateTest testWillResignActive (flutter/engine#23166)
gspencergoog
pushed a commit
to gspencergoog/engine
that referenced
this pull request
Jan 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates several places in
FlutterPlatformViewsTestsid.testSetFlutterViewControllerInTheMiddleOfTouchEventShouldStillAllowGesturesToBeHandledinto a new test as they are testing things a little differently.Related Issues
My fixes flutter/flutter#70843
Tests
I added the following tests:
testSetFlutterViewControllerInTheMiddleOfTouchEventAllowsTheNewControllerToHandleSecondTouchSequence
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.Reviewer Checklist
Breaking Change
Did any tests fail when you ran them? Please read handling breaking changes.