This repository has been archived by the owner on Feb 25, 2025. It is now read-only.
Fix bug where ImageGenerator factories with the same priority get dropped in release mode #29254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdero
force-pushed
the
bdero/fix-91421
branch
from
68e2b9d to
b672f22
Compare
bdero
force-pushed
the
bdero/fix-91421
branch
2 times, most recently
from
cd51690 to
3c1e736
Compare
zanderso
reviewed
Oct 20, 2021
bdero
force-pushed
the
bdero/fix-91421
branch
3 times, most recently
from
44740c9 to
9c73ce4
Compare
bdero
force-pushed
the
bdero/fix-91421
branch
from
9c73ce4 to
e98c57a
Compare
zanderso
approved these changes
Oct 20, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 20, 2021
kylinchen
pushed a commit
to XianyuTech/engine
that referenced
this pull request
Oct 22, 2021
|
@bdero Any chance this could make it into a hotfix? Images currently aren't working in my app properly because of this. If not, is there an approximate ETA for the stable channel? |
yx-mike
added a commit
to yx-mike/engine
that referenced
this pull request
Jan 12, 2022
yx-mike
added a commit
to yx-mike/engine
that referenced
this pull request
Jan 18, 2022
yx-mike
added a commit
to yx-mike/engine
that referenced
this pull request
May 18, 2022
… mode (flutter#29254)" This reverts commit 087a0f3.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#91421.
This was a silly one. I naively assumed that
fml::tracing::TraceNonce()was intended for global use, but in retrospect it's quite obvious that it's only intended for trace ordering. In release mode it's preprocessed out and only returns 0.