This repository has been archived by the owner on Feb 25, 2025. It is now read-only.
lint a few python scripts with pylint #33675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanderso
changed the title
dnfield
approved these changes
Jun 4, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 5, 2022
houhuayong
pushed a commit
to houhuayong/engine
that referenced
this pull request
Jun 21, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pylint is part of depot_tools and so should be available everywhere we need to run it.
The .pylintrc file is take from chromium with a couple modifications. First the line length is longer. This is the hard limit. The shorter soft limit is enforced by
yapf. Second, more lints are enabled that couldn't be enabled for chromium since they're violated in too many places in that codebase. Third, the limit on the number of local variables is increased from 15 to 25.Most of the changes needed in our scripts so far have been using single-quotes rather than double-quotes consistently, and using
snake_caserather thanUpperCamelCasefor function and method names.