-
Notifications
You must be signed in to change notification settings - Fork 6k
GLFW example with dirty region management #35057
Conversation
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
Given the additional complexity and build requirements not available on MacOS (EGL), can we make this a separate GLFW example? Perhaps under |
I agree that it would be nice to keep the example as simple as possible. I will add the partial repaint example as an extra then. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some comments about the build setup/running in CI and fetching extensions/doing proc resolution ahead of time. But overall looking good!
This looks like it should be good to go as soon as #35022 lands |
1001043
to
0db51f4
Compare
The changes proposed in this PR update the GLFW example to support dirty region management. It updates the example to a loading spinner in the center of the screen and adjusts the user-defined embedder callbacks to manage the information necessary for partial repaint. The goal of this example is also to serve as a local benchmark for dirty region management within the Embedder API.
Note: This PR is dependent on #35022.
Pre-launch Checklist
writing and running engine tests.
///
).