Instrument Image and Picture for leak tracking. #35274
Conversation
|
@yjbanov , can you advise, please - is it right understanding that I need to add instrumentation both in lib/ui and in lib/web_ui? |
The API should be identical, but if leak tracking a VM-only feature that doesn't have an equivalent in dart2js/DDC, then the web version can remain a noop. |
flutter-dashboard
bot
added
the
platform-web
|
Gold has detected about 37 new digest(s) on patchset 21. |
|
|
||
| ui.Image.onCreate = null; | ||
| // TODO(polina-c): unskip the test when bug is fixed: | ||
| // https://github.com/flutter/engine/pull/35791 |
There was a problem hiding this comment.
It was wrong URL. Replaced with right one. The issue is not fixed yet.
|
|
||
| ui.Image.onDispose = null; | ||
| // TODO(polina-c): unskip the test when bug is fixed: | ||
| // https://github.com/flutter/engine/pull/35791 |
| @@ -1681,6 +1700,7 @@ class Image { | |||
| /// useful when trying to determine what parts of the program are keeping an | |||
| /// image resident in memory. | |||
| void dispose() { | |||
| onDispose?.call(this); | |||
There was a problem hiding this comment.
Here and elsewhere: can we guard calling these so it's compiled out of release mode?
There was a problem hiding this comment.
As I know there is no compile time flags (like bool.fromEnvironment('flutter.memory_allocations')) in engine.
And 'normal' flags will not be more efficient both from performance perspective and code size perspective, than comparison to null. So there is no point in such guarding.
There was a problem hiding this comment.
Discussed offline - any flag we put in here would be at best a runtime check that's probably no faster than the null check here.
See go/dart-leaktracker-productization.
Before merging to https://github.com/flutter/engine/tree/main/lib: