Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert egl presentation time #36485

Merged
merged 2 commits into from
Sep 28, 2022
Merged

Revert egl presentation time #36485

merged 2 commits into from
Sep 28, 2022

Conversation

jonahwilliams
Copy link
Member

Partial revert of https://github.com/flutter/engine/pull/33881/files

From bisection, this feature is causing the jank observed in flutter/flutter#112503

iskakaushik
iskakaushik approved these changes Sep 28, 2022
View reviewed changes
Copy link
Contributor

@iskakaushik iskakaushik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonahwilliams jonahwilliams added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 28, 2022
@auto-submit auto-submit bot merged commit d7b64e2 into flutter:main Sep 28, 2022
@jonahwilliams jonahwilliams deleted the revert_egl_presentation_time branch September 28, 2022 21:54
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 28, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 28, 2022
@engine-flutter-autoroll
d7b64e2d9 Revert egl presentation time (flutter/engine#36485)
1e7f22a
@jonahwilliams jonahwilliams mentioned this pull request Sep 29, 2022
Closed
jonahwilliams added a commit to jonahwilliams/engine that referenced this pull request Sep 29, 2022
@jonahwilliams
Revert egl presentation time (flutter#36485)
a3cb758
@zanderso
Copy link
Member

For reference if/when re-landing, SkiaPerf flagged the movement of a benchmarks on this change:

https://flutter-flutter-perf.skia.org/e/?begin=1664214319&end=1664452663&keys=Xa601dd687b9ec7642225b0e3638c9422&requestType=0&selected=commit%3D31371%26name%3D%252Carch%253Dintel%252Cbranch%253Dmaster%252Cconfig%253Ddefault%252Cdevice_type%253DSM-G973U1%252Cdevice_version%253Dandroid-30%252Chost_type%253Dlinux%252Csub_result%253D90th_percentile_frame_build_time_millis%252Ctest%253Dplatform_views_scroll_perf__timeline_summary%252C&xbaroffset=31371

@zanderso
Copy link
Member

Also:

https://flutter-flutter-perf.skia.org/e/?begin=1664228847&end=1664452663&keys=Xb91eeca2368a023fcd30dd0a21f8531e&requestType=0&selected=commit%3D31371%26name%3D%252Carch%253Dintel%252Cbranch%253Dmaster%252Cconfig%253Ddefault%252Cdevice_type%253DMoto_G__4_%252Cdevice_version%253Dandroid-24%252Chost_type%253Dlinux%252Csub_result%253D90th_percentile_frame_rasterizer_time_millis%252Ctest%253Dflutter_gallery__transition_perf_hybrid%252C&xbaroffset=31371

itsjustkevin pushed a commit that referenced this pull request Sep 29, 2022
@jonahwilliams
Revert egl presentation time (#36485) (#36491)
c08d7d5
dnfield pushed a commit to dnfield/engine that referenced this pull request Sep 30, 2022
@jonahwilliams @dnfield
Revert egl presentation time (flutter#36485)
43a5597
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iskakaushik iskakaushik iskakaushik approved these changes

@dnfield dnfield Awaiting requested review from dnfield

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App platform-android
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonahwilliams @zanderso @iskakaushik