Fix invalid Unix locale to Flutter locale (BCP-47) mapping #36512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
robert-ancell
force-pushed
the
linux-locale-mapping
branch
from
4ddfaac to
9bf3ae6
Compare
cbracken
reviewed
Oct 1, 2022
|
@robert-ancell Is this still on your radar? |
robert-ancell
force-pushed
the
linux-locale-mapping
branch
4 times, most recently
from
7f09350 to
8960174
Compare
Flutter locales use the BCP-47 format (https://www.rfc-editor.org/rfc/bcp/bcp47.txt), and Unix locales use a POSIX format. There is not a perfect mapping between them, see https://wiki.openoffice.org/wiki/LocaleMapping The current implementation is not correctly setting the appropriate optional fields, so remove that. There are likely some Unix locales that should set these fields, but these are best fixed by adding special cases for them as they are discovered. Fixes: flutter/flutter#111341
robert-ancell
force-pushed
the
linux-locale-mapping
branch
from
8960174 to
8b3eb49
Compare
Was forgotten about, but I've added a test now. |
cbracken
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 19, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 20, 2023
…118852) * 27f6bbcb3 Fix invalid Unix locale to Flutter locale (BCP-47) mapping (flutter/engine#36512) * 7d40e77d0 Roll Skia from 69d8378097df to aedfc8695954 (4 revisions) (flutter/engine#38966)
ricardoamador
pushed a commit
to ricardoamador/engine
that referenced
this pull request
Jan 25, 2023
…6512) Flutter locales use the BCP-47 format (https://www.rfc-editor.org/rfc/bcp/bcp47.txt), and Unix locales use a POSIX format. There is not a perfect mapping between them, see https://wiki.openoffice.org/wiki/LocaleMapping The current implementation is not correctly setting the appropriate optional fields, so remove that. There are likely some Unix locales that should set these fields, but these are best fixed by adding special cases for them as they are discovered. Fixes: flutter/flutter#111341
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flutter locales use the BCP-47 format (https://www.rfc-editor.org/rfc/bcp/bcp47.txt), and Unix locales use a POSIX format. There is not a perfect mapping between them, see https://wiki.openoffice.org/wiki/LocaleMapping
The current implementation is not correctly setting the appropriate optional fields, so remove that.
There are likely some Unix locales that should set these fields, but these are best fixed by adding special cases for them as they are discovered.
Fixes: flutter/flutter#111341
Pre-launch Checklist
writing and running engine tests.
///).