-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "reland "Migrate darwin common "framework_shared" target to ARC #37049"" #37320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanderso
approved these changes
Nov 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add @gaaclarke if/when you want to reland this.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 4, 2022
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 4, 2022
…114714) * cf22fc23f Revert "reland "Migrate darwin common "framework_shared" target to ARC #37049" (#37219)" (flutter/engine#37320) * 3c5712bef Roll Dart SDK from 35b0cc8ac48b to b2aad7caafc9 (1 revision) (flutter/engine#37322) * 0933ca485 Revert "Roll Clang from a93d03310e2c to bca75abc01f3 (#37076)" (flutter/engine#37323)
cyanglaz
pushed a commit
to cyanglaz/engine
that referenced
this pull request
Nov 9, 2022
…et to ARC flutter#37049" (flutter#37219)" (flutter#37320)" This reverts commit cf22fc2.
cyanglaz
pushed a commit
to cyanglaz/engine
that referenced
this pull request
Nov 14, 2022
…et to ARC flutter#37049" (flutter#37219)" (flutter#37320)" This reverts commit cf22fc2. remove copy format
schwa423
pushed a commit
to schwa423/engine
that referenced
this pull request
Nov 16, 2022
…flutter#37049" (flutter#37219)" (flutter#37320) This reverts commit edb0492.
cyanglaz
pushed a commit
to cyanglaz/engine
that referenced
this pull request
Nov 23, 2022
…et to ARC flutter#37049" (flutter#37219)" (flutter#37320)" This reverts commit cf22fc2.
8 tasks
cyanglaz
pushed a commit
to cyanglaz/engine
that referenced
this pull request
Nov 29, 2022
…et to ARC flutter#37049" (flutter#37219)" (flutter#37320)" This reverts commit cf22fc2.
shogohida
pushed a commit
to shogohida/flutter
that referenced
this pull request
Dec 7, 2022
…lutter#114714) * cf22fc23f Revert "reland "Migrate darwin common "framework_shared" target to ARC flutter#37049" (flutter#37219)" (flutter/engine#37320) * 3c5712bef Roll Dart SDK from 35b0cc8ac48b to b2aad7caafc9 (1 revision) (flutter/engine#37322) * 0933ca485 Revert "Roll Clang from a93d03310e2c to bca75abc01f3 (flutter#37076)" (flutter/engine#37323)
cyanglaz
pushed a commit
to cyanglaz/engine
that referenced
this pull request
Dec 13, 2022
…et to ARC flutter#37049" (flutter#37219)" (flutter#37320)" This reverts commit cf22fc2.
loic-sharma
pushed a commit
to loic-sharma/flutter-engine
that referenced
this pull request
Dec 16, 2022
…et to ARC flutter#37049" (flutter#37219)" (flutter#37320)" (flutter#37883) This reverts commit cf22fc2.
loic-sharma
pushed a commit
to loic-sharma/flutter-engine
that referenced
this pull request
Jan 3, 2023
…et to ARC flutter#37049" (flutter#37219)" (flutter#37320)" (flutter#37883) This reverts commit cf22fc2.
gspencergoog
pushed a commit
to gspencergoog/flutter
that referenced
this pull request
Jan 19, 2023
…lutter#114714) * cf22fc23f Revert "reland "Migrate darwin common "framework_shared" target to ARC flutter#37049" (flutter#37219)" (flutter/engine#37320) * 3c5712bef Roll Dart SDK from 35b0cc8ac48b to b2aad7caafc9 (1 revision) (flutter/engine#37322) * 0933ca485 Revert "Roll Clang from a93d03310e2c to bca75abc01f3 (flutter#37076)" (flutter/engine#37323)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #37219
Potentially fixes flutter/flutter#114697