[canvaskit] Add test for image readPixels #37401

harryterkelsen · 2022-11-07T22:16:19Z

This is a regression test for flutter/flutter#94895

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
I listed at least one issue that this PR fixes in the description above.
I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
I updated/added relevant documentation (doc comments with ///).
I signed the CLA.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

yjbanov

…115008) * de0b58e82 clang-tidy: added the ability to shard jobs (flutter/engine#37265) * 8aefb8b61 Roll Dart SDK from d97d5ad98893 to b22b36c0f52e (1 revision) (flutter/engine#37400) * 2f043090f Roll Skia from aef6d301c0b5 to 0c8127b3dd7d (6 revisions) (flutter/engine#37402) * dc7cb20ad Fix boolean json property. (flutter/engine#37403) * 512fa40b6 Adding release_build:true property to windows builders. (flutter/engine#37397) * 0af87071f Add test for image readback (flutter/engine#37401) * c6f26e035 Update display_list_image_filter_unittests to be permit Skia roll (flutter/engine#37327) * 4e9e97b4b Roll Skia from 0c8127b3dd7d to 8b19fb0f57d4 (1 revision) (flutter/engine#37409) * 42c2940ff Pass the correct name for gclient variables in ci.yaml (flutter/engine#37429) * 2e2a2fd97 Revert "Roll Skia from 0c8127b3dd7d to 8b19fb0f57d4 (1 revision) (#37409)" (flutter/engine#37430) * 02cb78905 Roll Fuchsia Mac SDK from sa5bVGimNo3JwLV27... to d4l6A1aPw6Z0YjxmA... (flutter/engine#37432) * c24ae1872 [web] Use v8BreakIterator where possible (flutter/engine#37317) * 306b0fe9c Add rects to accumulator rather than bounds (flutter/engine#37435) * c76035429 Roll Dart SDK from b22b36c0f52e to c15cdb978761 (2 revisions) (flutter/engine#37437)

…lutter#115008) * de0b58e82 clang-tidy: added the ability to shard jobs (flutter/engine#37265) * 8aefb8b61 Roll Dart SDK from d97d5ad98893 to b22b36c0f52e (1 revision) (flutter/engine#37400) * 2f043090f Roll Skia from aef6d301c0b5 to 0c8127b3dd7d (6 revisions) (flutter/engine#37402) * dc7cb20ad Fix boolean json property. (flutter/engine#37403) * 512fa40b6 Adding release_build:true property to windows builders. (flutter/engine#37397) * 0af87071f Add test for image readback (flutter/engine#37401) * c6f26e035 Update display_list_image_filter_unittests to be permit Skia roll (flutter/engine#37327) * 4e9e97b4b Roll Skia from 0c8127b3dd7d to 8b19fb0f57d4 (1 revision) (flutter/engine#37409) * 42c2940ff Pass the correct name for gclient variables in ci.yaml (flutter/engine#37429) * 2e2a2fd97 Revert "Roll Skia from 0c8127b3dd7d to 8b19fb0f57d4 (1 revision) (flutter#37409)" (flutter/engine#37430) * 02cb78905 Roll Fuchsia Mac SDK from sa5bVGimNo3JwLV27... to d4l6A1aPw6Z0YjxmA... (flutter/engine#37432) * c24ae1872 [web] Use v8BreakIterator where possible (flutter/engine#37317) * 306b0fe9c Add rects to accumulator rather than bounds (flutter/engine#37435) * c76035429 Roll Dart SDK from b22b36c0f52e to c15cdb978761 (2 revisions) (flutter/engine#37437)

Add test for image readback

2715e48

flutter-dashboard bot added the platform-web Code specifically for the web engine label Nov 7, 2022

harryterkelsen requested a review from yjbanov November 7, 2022 22:16

yjbanov approved these changes Nov 7, 2022

View reviewed changes

harryterkelsen merged commit 0af8707 into flutter:main Nov 8, 2022

engine-flutter-autoroll mentioned this pull request Nov 8, 2022

Roll Flutter Engine from e7d7edab98ad to 0af87071fc7d (6 revisions) flutter/flutter#114863

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 8, 2022

0af87071f Add test for image readback (flutter/engine#37401)

8d7bf60

engine-flutter-autoroll mentioned this pull request Nov 8, 2022

Roll Flutter Engine from e7d7edab98ad to c6f26e035f81 (7 revisions) flutter/flutter#114873

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 8, 2022

0af87071f Add test for image readback (flutter/engine#37401)

083af02

engine-flutter-autoroll mentioned this pull request Nov 8, 2022

Roll Flutter Engine from e7d7edab98ad to c6f26e035f81 (7 revisions) flutter/flutter#114875

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 8, 2022

0af87071f Add test for image readback (flutter/engine#37401)

a1265a7

engine-flutter-autoroll mentioned this pull request Nov 8, 2022

Roll Flutter Engine from e7d7edab98ad to c6f26e035f81 (7 revisions) flutter/flutter#114883

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 8, 2022

0af87071f Add test for image readback (flutter/engine#37401)

9f5a667

engine-flutter-autoroll mentioned this pull request Nov 8, 2022

Roll Flutter Engine from e7d7edab98ad to 42c2940ff6fb (9 revisions) flutter/flutter#114903

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 8, 2022

0af87071f Add test for image readback (flutter/engine#37401)

4baaf40

engine-flutter-autoroll mentioned this pull request Nov 8, 2022

Roll Flutter Engine from e7d7edab98ad to 2e2a2fd97c64 (10 revisions) flutter/flutter#114904

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 8, 2022

0af87071f Add test for image readback (flutter/engine#37401)

092aca7

engine-flutter-autoroll mentioned this pull request Nov 8, 2022

Roll Flutter Engine from e7d7edab98ad to 02cb78905ac0 (11 revisions) flutter/flutter#114908

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 8, 2022

0af87071f Add test for image readback (flutter/engine#37401)

2bd10a3

engine-flutter-autoroll mentioned this pull request Nov 8, 2022

Roll Flutter Engine from e7d7edab98ad to c24ae1872927 (12 revisions) flutter/flutter#114909

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 8, 2022

0af87071f Add test for image readback (flutter/engine#37401)

796ad7c

engine-flutter-autoroll mentioned this pull request Nov 8, 2022

Roll Flutter Engine from e7d7edab98ad to 306b0fe9ccb1 (13 revisions) flutter/flutter#114910

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 8, 2022

0af87071f Add test for image readback (flutter/engine#37401)

6a8afea

engine-flutter-autoroll mentioned this pull request Nov 8, 2022

Roll Flutter Engine from e7d7edab98ad to c76035429c36 (14 revisions) flutter/flutter#114911

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 8, 2022

0af87071f Add test for image readback (flutter/engine#37401)

346ade3

engine-flutter-autoroll mentioned this pull request Nov 8, 2022

Roll Flutter Engine from e7d7edab98ad to 6daa75ad4cd5 (15 revisions) flutter/flutter#114912

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 8, 2022

0af87071f Add test for image readback (flutter/engine#37401)

876b05e

engine-flutter-autoroll mentioned this pull request Nov 8, 2022

Roll Flutter Engine from e7d7edab98ad to 6517ee8ee6d3 (16 revisions) flutter/flutter#114915

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 8, 2022

0af87071f Add test for image readback (flutter/engine#37401)

8605247

engine-flutter-autoroll mentioned this pull request Nov 9, 2022

Roll Flutter Engine from e7d7edab98ad to 05455ac0ade7 (23 revisions) flutter/flutter#114948

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 9, 2022

0af87071f Add test for image readback (flutter/engine#37401)

b485447

engine-flutter-autoroll mentioned this pull request Nov 9, 2022

Roll Flutter Engine from e7d7edab98ad to 410f270e61b6 (28 revisions) flutter/flutter#114961

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 9, 2022

0af87071f Add test for image readback (flutter/engine#37401)

50bcbca

engine-flutter-autoroll mentioned this pull request Nov 9, 2022

Roll Flutter Engine from e7d7edab98ad to e778ca4e0030 (29 revisions) flutter/flutter#114964

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 9, 2022

0af87071f Add test for image readback (flutter/engine#37401)

5ed6df2

engine-flutter-autoroll mentioned this pull request Nov 9, 2022

Roll Flutter Engine from e7d7edab98ad to f8048be39a7c (30 revisions) flutter/flutter#114969

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 9, 2022

0af87071f Add test for image readback (flutter/engine#37401)

bccc2cf

engine-flutter-autoroll mentioned this pull request Nov 9, 2022

Roll Flutter Engine from e7d7edab98ad to 214b84137bbe (31 revisions) flutter/flutter#114972

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 9, 2022

0af87071f Add test for image readback (flutter/engine#37401)

6ac6993

engine-flutter-autoroll mentioned this pull request Nov 9, 2022

Roll Flutter Engine from e7d7edab98ad to 214b84137bbe (31 revisions) flutter/flutter#114976

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 9, 2022

0af87071f Add test for image readback (flutter/engine#37401)

e423722

engine-flutter-autoroll mentioned this pull request Nov 9, 2022

Roll Flutter Engine from e7d7edab98ad to 8ecb1c913ba5 (32 revisions) flutter/flutter#114977

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 9, 2022

0af87071f Add test for image readback (flutter/engine#37401)

41b4850

engine-flutter-autoroll mentioned this pull request Nov 9, 2022

Roll Flutter Engine from e7d7edab98ad to 2e2a2fd97c64 (10 revisions) flutter/flutter#114996

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 9, 2022

0af87071f Add test for image readback (flutter/engine#37401)

bf011fc

engine-flutter-autoroll mentioned this pull request Nov 9, 2022

Roll Flutter Engine from e7d7edab98ad to 1a8888b5170b (33 revisions) flutter/flutter#114997

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 9, 2022

0af87071f Add test for image readback (flutter/engine#37401)

76be5be

engine-flutter-autoroll mentioned this pull request Nov 9, 2022

Roll Flutter Engine from e7d7edab98ad to ca303bfd4eed (34 revisions) flutter/flutter#115001

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 9, 2022

0af87071f Add test for image readback (flutter/engine#37401)

a5eed22

engine-flutter-autoroll mentioned this pull request Nov 9, 2022

Roll Flutter Engine from e7d7edab98ad to 5d0df764b03a (35 revisions) flutter/flutter#115003

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 9, 2022

0af87071f Add test for image readback (flutter/engine#37401)

0c91ad4

engine-flutter-autoroll mentioned this pull request Nov 9, 2022

Roll Flutter Engine from e7d7edab98ad to c76035429c36 (14 revisions) flutter/flutter#115008

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 9, 2022

0af87071f Add test for image readback (flutter/engine#37401)

fe8c8ab

naudzghebre pushed a commit to naudzghebre/engine that referenced this pull request Nov 9, 2022

Add test for image readback (flutter#37401)

4165098

engine-flutter-autoroll mentioned this pull request Nov 9, 2022

Roll Flutter Engine from e7d7edab98ad to 5f88ee42b1c3 (37 revisions) flutter/flutter#115011

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 9, 2022

0af87071f Add test for image readback (flutter/engine#37401)

03ab149

schwa423 pushed a commit to schwa423/engine that referenced this pull request Nov 16, 2022

Add test for image readback (flutter#37401)

8d25c5d

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[canvaskit] Add test for image readPixels #37401

[canvaskit] Add test for image readPixels #37401

harryterkelsen commented Nov 7, 2022

yjbanov left a comment

[canvaskit] Add test for image readPixels #37401

[canvaskit] Add test for image readPixels #37401

Conversation

harryterkelsen commented Nov 7, 2022

Pre-launch Checklist

yjbanov left a comment

Choose a reason for hiding this comment