This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Use traingle strip for difference clip #37469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was wrongly removed in flutter#37315 where I assumed that this was overwritten by geometry_result a few lines below, but there is indeed a pipeline created earlier in line:100. Fixes: flutter/flutter#114870
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 9, 2022
naudzghebre
pushed a commit
to naudzghebre/engine
that referenced
this pull request
Nov 9, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 9, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 9, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 9, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 9, 2022
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 9, 2022
…115025) * 6daa75ad4 Roll Skia from 0c8127b3dd7d to 6a056a26b3c5 (16 revisions) (flutter/engine#37438) * 6517ee8ee Roll Skia from 6a056a26b3c5 to 3cecb22c5827 (1 revision) (flutter/engine#37439) * c1200c44f Sdk roll failure - add facet to allowlist test_manager and other packages. (flutter/engine#37395) * 179154ec1 Revert "Sdk roll failure - add facet to allowlist test_manager and other packages. (#37395)" (flutter/engine#37449) * c171f27c4 Revert "Add rects to accumulator rather than bounds (#37435)" (flutter/engine#37444) * 583c71ce4 Clang-tidy: Fixed math on shard-id validator. (flutter/engine#37433) * d224648fc Roll Skia from 3cecb22c5827 to 94450cd1df4e (4 revisions) (flutter/engine#37445) * 5df42a87b Oops, accidentally compiled the non-null-safe platform file as null safe. (flutter/engine#37453) * 05455ac0a Roll Skia from 94450cd1df4e to 22526b55be02 (6 revisions) (flutter/engine#37455) * 9628070ee Roll Skia from 22526b55be02 to 511aa59461f3 (1 revision) (flutter/engine#37458) * fc7293441 [Impeller] Don't double-convert include path encodings in ImpellerC (flutter/engine#37408) * d82a2df8a Roll Skia from 511aa59461f3 to 790aedd91cd8 (2 revisions) (flutter/engine#37463) * be54e3ea0 Roll Skia from 790aedd91cd8 to fe143a0dc368 (3 revisions) (flutter/engine#37467) * 410f270e6 Roll Dart SDK from c15cdb978761 to 874a662f7507 (3 revisions) (flutter/engine#37466) * e778ca4e0 Roll Fuchsia Mac SDK from d4l6A1aPw6Z0YjxmA... to vEw8iuSZYmlfk1JiE... (flutter/engine#37468) * f8048be39 [Reland] Add rects to accumulator rather than bounds (#37435) (flutter/engine#37451) * 214b84137 Roll Dart SDK from 874a662f7507 to 4fcefaf03496 (1 revision) (flutter/engine#37470) * 8ecb1c913 [macOS] Remove OpenGL rendering backend (flutter/engine#37448) * 1a8888b51 Roll Skia from fe143a0dc368 to 0854badd5783 (1 revision) (flutter/engine#37471) * ca303bfd4 Roll Dart SDK from 4fcefaf03496 to fa6586382e5d (1 revision) (flutter/engine#37473) * 5d0df764b Use traingle strip for difference clip (flutter/engine#37469) * eeba9b3c8 Support HLSL ingestion in ImpellerC (flutter/engine#37461) * 5f88ee42b Use IndexError.check instead of RangeError.checkValidIndex in buffers. (flutter/engine#37450) * b65ac4ac4 Roll expat to 2.5.0 (flutter/engine#37383) * ddde8300e [sdk_roll_failure] add facet to allowlist test_manager and other packages. (flutter/engine#37479) * 62b581ee0 Roll CanvasKit to 0.37.1 (flutter/engine#37454) * aa4b3ea2f Turned on performance-unnecessary-value-param everywhere. (flutter/engine#37447)
zanderso
pushed a commit
to zanderso/engine
that referenced
this pull request
Nov 12, 2022
zanderso
pushed a commit
to zanderso/engine
that referenced
this pull request
Nov 15, 2022
schwa423
pushed a commit
to schwa423/engine
that referenced
this pull request
Nov 16, 2022
zanderso
pushed a commit
to zanderso/engine
that referenced
this pull request
Nov 16, 2022
zanderso
added a commit
that referenced
this pull request
Nov 16, 2022
…#37558) * Use traingle strip for difference clip (#37469) * [Impeller] Include the new primitive type in the pipeline hash (#37546) * Include the new primitive type in the pipeline hash * Add test Co-authored-by: Kaushik Iska <[email protected]> Co-authored-by: Brandon DeRosier <[email protected]>
shogohida
pushed a commit
to shogohida/flutter
that referenced
this pull request
Dec 7, 2022
…lutter#115025) * 6daa75ad4 Roll Skia from 0c8127b3dd7d to 6a056a26b3c5 (16 revisions) (flutter/engine#37438) * 6517ee8ee Roll Skia from 6a056a26b3c5 to 3cecb22c5827 (1 revision) (flutter/engine#37439) * c1200c44f Sdk roll failure - add facet to allowlist test_manager and other packages. (flutter/engine#37395) * 179154ec1 Revert "Sdk roll failure - add facet to allowlist test_manager and other packages. (flutter#37395)" (flutter/engine#37449) * c171f27c4 Revert "Add rects to accumulator rather than bounds (flutter#37435)" (flutter/engine#37444) * 583c71ce4 Clang-tidy: Fixed math on shard-id validator. (flutter/engine#37433) * d224648fc Roll Skia from 3cecb22c5827 to 94450cd1df4e (4 revisions) (flutter/engine#37445) * 5df42a87b Oops, accidentally compiled the non-null-safe platform file as null safe. (flutter/engine#37453) * 05455ac0a Roll Skia from 94450cd1df4e to 22526b55be02 (6 revisions) (flutter/engine#37455) * 9628070ee Roll Skia from 22526b55be02 to 511aa59461f3 (1 revision) (flutter/engine#37458) * fc7293441 [Impeller] Don't double-convert include path encodings in ImpellerC (flutter/engine#37408) * d82a2df8a Roll Skia from 511aa59461f3 to 790aedd91cd8 (2 revisions) (flutter/engine#37463) * be54e3ea0 Roll Skia from 790aedd91cd8 to fe143a0dc368 (3 revisions) (flutter/engine#37467) * 410f270e6 Roll Dart SDK from c15cdb978761 to 874a662f7507 (3 revisions) (flutter/engine#37466) * e778ca4e0 Roll Fuchsia Mac SDK from d4l6A1aPw6Z0YjxmA... to vEw8iuSZYmlfk1JiE... (flutter/engine#37468) * f8048be39 [Reland] Add rects to accumulator rather than bounds (flutter#37435) (flutter/engine#37451) * 214b84137 Roll Dart SDK from 874a662f7507 to 4fcefaf03496 (1 revision) (flutter/engine#37470) * 8ecb1c913 [macOS] Remove OpenGL rendering backend (flutter/engine#37448) * 1a8888b51 Roll Skia from fe143a0dc368 to 0854badd5783 (1 revision) (flutter/engine#37471) * ca303bfd4 Roll Dart SDK from 4fcefaf03496 to fa6586382e5d (1 revision) (flutter/engine#37473) * 5d0df764b Use traingle strip for difference clip (flutter/engine#37469) * eeba9b3c8 Support HLSL ingestion in ImpellerC (flutter/engine#37461) * 5f88ee42b Use IndexError.check instead of RangeError.checkValidIndex in buffers. (flutter/engine#37450) * b65ac4ac4 Roll expat to 2.5.0 (flutter/engine#37383) * ddde8300e [sdk_roll_failure] add facet to allowlist test_manager and other packages. (flutter/engine#37479) * 62b581ee0 Roll CanvasKit to 0.37.1 (flutter/engine#37454) * aa4b3ea2f Turned on performance-unnecessary-value-param everywhere. (flutter/engine#37447)
gspencergoog
pushed a commit
to gspencergoog/flutter
that referenced
this pull request
Jan 19, 2023
…lutter#115025) * 6daa75ad4 Roll Skia from 0c8127b3dd7d to 6a056a26b3c5 (16 revisions) (flutter/engine#37438) * 6517ee8ee Roll Skia from 6a056a26b3c5 to 3cecb22c5827 (1 revision) (flutter/engine#37439) * c1200c44f Sdk roll failure - add facet to allowlist test_manager and other packages. (flutter/engine#37395) * 179154ec1 Revert "Sdk roll failure - add facet to allowlist test_manager and other packages. (flutter#37395)" (flutter/engine#37449) * c171f27c4 Revert "Add rects to accumulator rather than bounds (flutter#37435)" (flutter/engine#37444) * 583c71ce4 Clang-tidy: Fixed math on shard-id validator. (flutter/engine#37433) * d224648fc Roll Skia from 3cecb22c5827 to 94450cd1df4e (4 revisions) (flutter/engine#37445) * 5df42a87b Oops, accidentally compiled the non-null-safe platform file as null safe. (flutter/engine#37453) * 05455ac0a Roll Skia from 94450cd1df4e to 22526b55be02 (6 revisions) (flutter/engine#37455) * 9628070ee Roll Skia from 22526b55be02 to 511aa59461f3 (1 revision) (flutter/engine#37458) * fc7293441 [Impeller] Don't double-convert include path encodings in ImpellerC (flutter/engine#37408) * d82a2df8a Roll Skia from 511aa59461f3 to 790aedd91cd8 (2 revisions) (flutter/engine#37463) * be54e3ea0 Roll Skia from 790aedd91cd8 to fe143a0dc368 (3 revisions) (flutter/engine#37467) * 410f270e6 Roll Dart SDK from c15cdb978761 to 874a662f7507 (3 revisions) (flutter/engine#37466) * e778ca4e0 Roll Fuchsia Mac SDK from d4l6A1aPw6Z0YjxmA... to vEw8iuSZYmlfk1JiE... (flutter/engine#37468) * f8048be39 [Reland] Add rects to accumulator rather than bounds (flutter#37435) (flutter/engine#37451) * 214b84137 Roll Dart SDK from 874a662f7507 to 4fcefaf03496 (1 revision) (flutter/engine#37470) * 8ecb1c913 [macOS] Remove OpenGL rendering backend (flutter/engine#37448) * 1a8888b51 Roll Skia from fe143a0dc368 to 0854badd5783 (1 revision) (flutter/engine#37471) * ca303bfd4 Roll Dart SDK from 4fcefaf03496 to fa6586382e5d (1 revision) (flutter/engine#37473) * 5d0df764b Use traingle strip for difference clip (flutter/engine#37469) * eeba9b3c8 Support HLSL ingestion in ImpellerC (flutter/engine#37461) * 5f88ee42b Use IndexError.check instead of RangeError.checkValidIndex in buffers. (flutter/engine#37450) * b65ac4ac4 Roll expat to 2.5.0 (flutter/engine#37383) * ddde8300e [sdk_roll_failure] add facet to allowlist test_manager and other packages. (flutter/engine#37479) * 62b581ee0 Roll CanvasKit to 0.37.1 (flutter/engine#37454) * aa4b3ea2f Turned on performance-unnecessary-value-param everywhere. (flutter/engine#37447)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was wrongly removed in #37315 where I assumed that this was overwritten by geometry_result a few lines below, but there is indeed a pipeline created earlier in line:100.
Fixes: flutter/flutter#114870