Run pub get before building host.dart. #37502

eyebrowsoffire · 2022-11-11T00:08:43Z

No description provided.

flutter-dashboard · 2022-11-11T00:08:45Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

ditman

LGTM! (Very common change in the plugins CI too :P)

mdebbar

We already do this in:

engine/lib/web_ui/dev/felt

Lines 89 to 95 in 645d4e3

    
           install_deps() { 
        
             echo "Running \`dart pub get\` in 'engine/src/flutter/lib/web_ui'" 
        
             (cd "$WEB_UI_DIR"; $DART_PATH pub get) 
        
             echo "Running \`dart pub get\` in 'engine/src/flutter/web_sdk/web_engine_tester'" 
        
             (cd "$FLUTTER_DIR/web_sdk/web_engine_tester"; $DART_PATH pub get) 
        
           }

Are there certain cases where that's not enough?

felt itself needs it. However, we should let felt invoke `pub get` on `web_engine_tester` only as needed, not in the launcher script.

mdebbar

LGTM! Thanks for fixing this!

…115185) * 645d4e313 Roll Dart SDK from 1e37edb1f6c1 to 2b6909ba35e5 (1 revision) (flutter/engine#37516) * 4cbfe4238 Build display lists from SkParagraph output using the ParagraphPainter interface (flutter/engine#37087) * 05649893f Roll Skia from 77620568f467 to 1a7879e4e26a (6 revisions) (flutter/engine#37520) * f48be3491 Run pub get before building host.dart. (flutter/engine#37502) * e815a60a7 Roll Skia from 1a7879e4e26a to a457da8acd16 (5 revisions) (flutter/engine#37524) * 0f93194b7 Roll ICU from 20f8ac695af5 to da0744861976 (1 revision) (flutter/engine#37525) * 329900fc8 Roll Skia from a457da8acd16 to 29b9dbd7a8ed (1 revision) (flutter/engine#37528)

* Run pub get before building host.dart. * We should call `pub get` for `web_ui` in the launcher script because felt itself needs it. However, we should let felt invoke `pub get` on `web_engine_tester` only as needed, not in the launcher script.

* clang-tidy: added the ability to shard jobs (#37265) * clang-tidy: added the ability to shard jobs * added test * jenn feedback * hack ci to run as a shard to measure the time * tweak * fix hack * zach feedback * zach feedback 2 * removed stray async * moved to using sets for lookups * fixed typo in docstring * Revert "fix hack" This reverts commit 06a61a6. Revert "tweak" This reverts commit e7c58b1. Revert "hack ci to run as a shard to measure the time" This reverts commit e458963. * removed calls to map * turned the ci hack back on * Revert "turned the ci hack back on" This reverts commit 0d53794. * removed sync* * Clang-tidy: Fixed math on shard-id validator. (#37433) Clang-tidy: Fixed math on shard-id validator. * Felt analyze (#37481) * Adding `felt analyze` command that CI will run. * Remove some copypasta'd stuff. * Also remove code path from felt.dart that forces a rebuild if it doesn't detect the host_debug_unopt directory. * More cleanup of felt.bat for CI. * Fix typo in felt.bat. * Run pub get before building host.dart. (#37502) * Run pub get before building host.dart. * We should call `pub get` for `web_ui` in the launcher script because felt itself needs it. However, we should let felt invoke `pub get` on `web_engine_tester` only as needed, not in the launcher script. * Skip the skwasm unit test suite on Safari since it is flaky. (#37602) * Skip the skwasm unit test suite on Safari since it is flaky. * Add TODO. * Remove felt snapshotting behavior. (#37639) * Remove felt snapshotting behavior. * Use `dart run`. * Combine results of all the test batches. (#37610) * Combine results of all the test batches. * Skip regressions * Use bool instead * remove unused var * skip fragment_program_test * Also skip GL context lost test * Transparent background test fails on Firefox and Safari * Skip other test in safari * Skip text test on firefox Co-authored-by: gaaclarke <[email protected]> Co-authored-by: Jackson Gardner <[email protected]> Co-authored-by: Harry Terkelsen <[email protected]>

…lutter#115185) * 645d4e313 Roll Dart SDK from 1e37edb1f6c1 to 2b6909ba35e5 (1 revision) (flutter/engine#37516) * 4cbfe4238 Build display lists from SkParagraph output using the ParagraphPainter interface (flutter/engine#37087) * 05649893f Roll Skia from 77620568f467 to 1a7879e4e26a (6 revisions) (flutter/engine#37520) * f48be3491 Run pub get before building host.dart. (flutter/engine#37502) * e815a60a7 Roll Skia from 1a7879e4e26a to a457da8acd16 (5 revisions) (flutter/engine#37524) * 0f93194b7 Roll ICU from 20f8ac695af5 to da0744861976 (1 revision) (flutter/engine#37525) * 329900fc8 Roll Skia from a457da8acd16 to 29b9dbd7a8ed (1 revision) (flutter/engine#37528)

Run pub get before building host.dart.

03dbff7

flutter-dashboard bot added platform-web Code specifically for the web engine needs tests labels Nov 11, 2022

ditman approved these changes Nov 11, 2022

View reviewed changes

mdebbar reviewed Nov 11, 2022

View reviewed changes

We should call pub get for web_ui in the launcher script because

0aa3e31

felt itself needs it. However, we should let felt invoke `pub get` on `web_engine_tester` only as needed, not in the launcher script.

mdebbar approved these changes Nov 11, 2022

View reviewed changes

eyebrowsoffire added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 11, 2022

auto-submit bot merged commit f48be34 into flutter:main Nov 11, 2022

engine-flutter-autoroll mentioned this pull request Nov 11, 2022

Roll Flutter Engine from 7326e5b3354b to f48be3491425 (4 revisions) flutter/flutter#115167

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 11, 2022

f48be3491 Run pub get before building host.dart. (flutter/engine#37502)

0d0f51b

engine-flutter-autoroll mentioned this pull request Nov 11, 2022

Roll Flutter Engine from 7326e5b3354b to e815a60a771b (5 revisions) flutter/flutter#115172

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 11, 2022

f48be3491 Run pub get before building host.dart. (flutter/engine#37502)

1ce6e05

engine-flutter-autoroll mentioned this pull request Nov 11, 2022

Roll Flutter Engine from 7326e5b3354b to 0f93194b79ea (6 revisions) flutter/flutter#115177

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 11, 2022

f48be3491 Run pub get before building host.dart. (flutter/engine#37502)

acfc668

engine-flutter-autoroll mentioned this pull request Nov 11, 2022

Roll Flutter Engine from 7326e5b3354b to 329900fc85d6 (7 revisions) flutter/flutter#115180

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 11, 2022

f48be3491 Run pub get before building host.dart. (flutter/engine#37502)

84f1296

engine-flutter-autoroll mentioned this pull request Nov 11, 2022

Roll Flutter Engine from 7326e5b3354b to 329900fc85d6 (7 revisions) flutter/flutter#115185

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 11, 2022

f48be3491 Run pub get before building host.dart. (flutter/engine#37502)

61fb5a4

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Run pub get before building host.dart. #37502

Run pub get before building host.dart. #37502

eyebrowsoffire commented Nov 11, 2022

flutter-dashboard bot commented Nov 11, 2022

ditman left a comment

mdebbar left a comment

mdebbar left a comment

	install_deps() {
	echo "Running \`dart pub get\` in 'engine/src/flutter/lib/web_ui'"
	(cd "$WEB_UI_DIR"; $DART_PATH pub get)

	echo "Running \`dart pub get\` in 'engine/src/flutter/web_sdk/web_engine_tester'"
	(cd "$FLUTTER_DIR/web_sdk/web_engine_tester"; $DART_PATH pub get)
	}

Run pub get before building host.dart. #37502

Run pub get before building host.dart. #37502

Conversation

eyebrowsoffire commented Nov 11, 2022

flutter-dashboard bot commented Nov 11, 2022

ditman left a comment

Choose a reason for hiding this comment

mdebbar left a comment

Choose a reason for hiding this comment

mdebbar left a comment

Choose a reason for hiding this comment