Skip to content
This repository has been archived by the owner on Feb 25, 2025. It is now read-only.

[Impeller] reuse texture if size and type matches #37527

Merged
merged 3 commits into from
Nov 12, 2022

Conversation

jonahwilliams
Copy link
Member

Might help slightly, still need to pay the cost of reupload though

Copy link
Contributor

@dnfield dnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'm curious if this helps with any metal runtime warnings about late texture creation in subsequent frames.

@jonahwilliams jonahwilliams added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 12, 2022
@auto-submit auto-submit bot merged commit 9500d8c into flutter:main Nov 12, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 12, 2022
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Nov 12, 2022
…115212)

* 4b4169421 Roll Fuchsia Linux SDK from xDY5B0-NZzq2idRNU... to IE4logHFoa8ZZQAw3... (flutter/engine#37554)

* 9500d8c4a [Impeller] reuse texture if size and type matches (flutter/engine#37527)
schwa423 pushed a commit to schwa423/engine that referenced this pull request Nov 16, 2022
@jonahwilliams jonahwilliams deleted the reuse-texture branch November 17, 2022 21:04
jonahwilliams added a commit that referenced this pull request Nov 17, 2022
auto-submit bot pushed a commit that referenced this pull request Nov 17, 2022
shogohida pushed a commit to shogohida/flutter that referenced this pull request Dec 7, 2022
…lutter#115212)

* 4b4169421 Roll Fuchsia Linux SDK from xDY5B0-NZzq2idRNU... to IE4logHFoa8ZZQAw3... (flutter/engine#37554)

* 9500d8c4a [Impeller] reuse texture if size and type matches (flutter/engine#37527)
gspencergoog pushed a commit to gspencergoog/flutter that referenced this pull request Jan 19, 2023
…lutter#115212)

* 4b4169421 Roll Fuchsia Linux SDK from xDY5B0-NZzq2idRNU... to IE4logHFoa8ZZQAw3... (flutter/engine#37554)

* 9500d8c4a [Impeller] reuse texture if size and type matches (flutter/engine#37527)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
autosubmit Merge PR when tree becomes green via auto submit App e: impeller
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants