Skip to content
This repository has been archived by the owner on Feb 25, 2025. It is now read-only.

Revert "Fix wrong VSYNC event" #37589

Merged
merged 1 commit into from
Nov 14, 2022
Merged

Revert "Fix wrong VSYNC event" #37589

merged 1 commit into from
Nov 14, 2022

Conversation

dnfield
Copy link
Contributor

@dnfield dnfield commented Nov 14, 2022

@dnfield dnfield requested a review from iskakaushik November 14, 2022 18:25
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@dnfield
Copy link
Contributor Author

dnfield commented Nov 14, 2022

@fzyzcjy fyi

@dnfield dnfield mentioned this pull request Nov 14, 2022
Closed
jonahwilliams
jonahwilliams approved these changes Nov 14, 2022
View reviewed changes
Copy link
Member

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dnfield dnfield added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 14, 2022
@auto-submit auto-submit bot merged commit 9cf107b into main Nov 14, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 14, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 14, 2022
@engine-flutter-autoroll
9cf107b19 Revert "Fix wrong VSYNC event (flutter#36775)" (flutter/e…
a215e7a 
…ngine#37589)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Nov 14, 2022
@engine-flutter-autoroll
Roll Flutter Engine from 1a79e8686036 to 8c73ffff5b6f (2 revisions) (#…
59e1edc 
…115302)

* 9cf107b19 Revert "Fix wrong `VSYNC` event (#36775)" (flutter/engine#37589)

* 8c73ffff5 Fix unexpected masked action (flutter/engine#37584)
@fzyzcjy
Copy link
Contributor

fzyzcjy commented Nov 14, 2022

:( So vsync is completely wrong again now

Does flutter/flutter#115161 (comment) proposal looks ok? If so I will PR

@dnfield dnfield deleted the revert-36775-feat/correct-vsync-timeline branch November 15, 2022 19:58
schwa423 pushed a commit to schwa423/engine that referenced this pull request Nov 16, 2022
@dnfield @schwa423
Revert "Fix wrong VSYNC event (flutter#36775)" (flutter#37589)
a83afaa 
This reverts commit 9ccaa33.
@fzyzcjy fzyzcjy mentioned this pull request Nov 23, 2022
Merged
8 tasks
shogohida pushed a commit to shogohida/flutter that referenced this pull request Dec 7, 2022
@engine-flutter-autoroll @shogohida
Roll Flutter Engine from 1a79e8686036 to 8c73ffff5b6f (2 revisions) (f…
1646f56 
…lutter#115302)

* 9cf107b19 Revert "Fix wrong `VSYNC` event (flutter#36775)" (flutter/engine#37589)

* 8c73ffff5 Fix unexpected masked action (flutter/engine#37584)
gspencergoog pushed a commit to gspencergoog/flutter that referenced this pull request Jan 19, 2023
@engine-flutter-autoroll @gspencergoog
Roll Flutter Engine from 1a79e8686036 to 8c73ffff5b6f (2 revisions) (f…
5f1aeef 
…lutter#115302)

* 9cf107b19 Revert "Fix wrong `VSYNC` event (flutter#36775)" (flutter/engine#37589)

* 8c73ffff5 Fix unexpected masked action (flutter/engine#37584)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jonahwilliams jonahwilliams jonahwilliams approved these changes

@iskakaushik iskakaushik Awaiting requested review from iskakaushik

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App needs tests platform-android platform-ios
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dnfield @fzyzcjy @jonahwilliams