This repository has been archived by the owner on Feb 25, 2025. It is now read-only.
Shader warmup #37662
Merged
Shader warmup #37662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uysalere
reviewed
Nov 16, 2022
| @@ -184,7 +184,7 @@ VulkanSurface::~VulkanSurface() { | |||
| if (buffer_id_) { | |||
| session_->DeregisterBufferCollection(buffer_id_); | |||
| } | |||
| } else { | |||
| } else if (release_image_callback_) { | |||
There was a problem hiding this comment.
This change lgtm. But we should clean up the other files from the pull request.
There was a problem hiding this comment.
Rebased change onto main, now there's only 1 line changed in 1 file.
Before, ~VulkanSurface() invokes a potentially empty std::function. Now, checks if it is empty before invoking it.
schwa423
force-pushed
the
shader_warmup
branch
from
57ae052 to
1e93101
Compare
uysalere
approved these changes
Nov 16, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 16, 2022
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 16, 2022
…115478) * 7a5bc9124 Roll Skia from 4b3d36f36bf3 to 74a57221dfb3 (7 revisions) (flutter/engine#37675) * f4ca3e7a0 [fuchsia] Fix shader warmup. (flutter/engine#37662) * 97974ebb5 Fix resize crash in Android virtual display (flutter/engine#37329)
shogohida
pushed a commit
to shogohida/flutter
that referenced
this pull request
Dec 7, 2022
…lutter#115478) * 7a5bc9124 Roll Skia from 4b3d36f36bf3 to 74a57221dfb3 (7 revisions) (flutter/engine#37675) * f4ca3e7a0 [fuchsia] Fix shader warmup. (flutter/engine#37662) * 97974ebb5 Fix resize crash in Android virtual display (flutter/engine#37329)
gspencergoog
pushed a commit
to gspencergoog/flutter
that referenced
this pull request
Jan 19, 2023
…lutter#115478) * 7a5bc9124 Roll Skia from 4b3d36f36bf3 to 74a57221dfb3 (7 revisions) (flutter/engine#37675) * f4ca3e7a0 [fuchsia] Fix shader warmup. (flutter/engine#37662) * 97974ebb5 Fix resize crash in Android virtual display (flutter/engine#37329)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes illegal behavior in the ~VulkanSurface() destructor, which invokes a
std::functionwithout first checking if it is empty; it will be empty if nobody callsVulkanSurface::SetReleaseImageCallback(). This is true in the case of Skia shader warmup on Fuchsia.This CL fixes the following issue: https://bugs.fuchsia.dev/p/fuchsia/issues/detail?id=115400
Note: the root cause is not directly related to shader warmup, and could potentially manifest in other situations (not after this PR is merged though).
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.