Skip to content
This repository has been archived by the owner on Feb 25, 2025. It is now read-only.

[Impeller] Fix glyph atlas uploads and renders #37691

Merged
merged 1 commit into from
Nov 17, 2022
Merged

[Impeller] Fix glyph atlas uploads and renders #37691

merged 1 commit into from
Nov 17, 2022

Conversation

iskakaushik
Copy link
Contributor

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

bdero
bdero approved these changes Nov 16, 2022
View reviewed changes
Copy link
Member

@bdero bdero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@iskakaushik iskakaushik added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 16, 2022
@auto-submit
Copy link
Contributor

auto-submit bot commented Nov 17, 2022

auto label is removed for flutter/engine, pr: 37691, due to - The status or check suite Mac mac_host_engine has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Nov 17, 2022
@iskakaushik iskakaushik merged commit fa7e196 into flutter:main Nov 17, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 17, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 17, 2022
@engine-flutter-autoroll
fa7e1965e [Impeller] Fix glyph atlas uploads and renders (flutter/eng…
0dd51a4 
…ine#37691)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Nov 17, 2022
@engine-flutter-autoroll
fa7e1965e [Impeller] Fix glyph atlas uploads and renders (flutter/eng…
31f8631 
…ine#37691) (#115556)
sourcegraph-bot pushed a commit to sgtest/megarepo that referenced this pull request Nov 17, 2022
flutter: fa7e1965e [Impeller] Fix glyph atlas uploads and renders (fl…
a5e01c1 
…utter/engine#37691) (#115556)

Commit: 31f86316272c64297979c78c7032315f2af86896
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 17, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Nov 17, 2022
@engine-flutter-autoroll
31f8631 fa7e1965e [Impeller] Fix glyph atlas uploads and renders (flu…
830f0ed 
…tter/engine#37691) (flutter/flutter#115556)
This was referenced Nov 18, 2022
Merged
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 18, 2022
@engine-flutter-autoroll
31f8631 fa7e1965e [Impeller] Fix glyph atlas uploads and renders (flu…
eb503c5 
…tter/engine#37691) (flutter/flutter#115556)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Nov 18, 2022
@engine-flutter-autoroll
31f8631 fa7e1965e [Impeller] Fix glyph atlas uploads and renders (flu…
3126f8c 
…tter/engine#37691) (flutter/flutter#115556)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 18, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Nov 18, 2022
@engine-flutter-autoroll
31f8631 fa7e1965e [Impeller] Fix glyph atlas uploads and renders (flu…
40b9529 
…tter/engine#37691) (flutter/flutter#115556)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 18, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Nov 18, 2022
@engine-flutter-autoroll
31f8631 fa7e1965e [Impeller] Fix glyph atlas uploads and renders (flu…
8990398 
…tter/engine#37691) (flutter/flutter#115556)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 18, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Nov 18, 2022
@engine-flutter-autoroll
31f8631 fa7e1965e [Impeller] Fix glyph atlas uploads and renders (flu…
43d2b28 
…tter/engine#37691) (flutter/flutter#115556)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 18, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Nov 18, 2022
@engine-flutter-autoroll
31f8631 fa7e1965e [Impeller] Fix glyph atlas uploads and renders (flu…
c3f6bf1 
…tter/engine#37691) (flutter/flutter#115556)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 18, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Nov 18, 2022
@engine-flutter-autoroll
31f8631 fa7e1965e [Impeller] Fix glyph atlas uploads and renders (flu…
9aaaee8 
…tter/engine#37691) (flutter/flutter#115556)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 18, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Nov 18, 2022
@engine-flutter-autoroll
31f8631 fa7e1965e [Impeller] Fix glyph atlas uploads and renders (flu…
ea39b26 
…tter/engine#37691) (flutter/flutter#115556)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Nov 18, 2022
@engine-flutter-autoroll
Roll Flutter from 537f89c to 18c8727 (31 revisions) (#2822)
090ebf6 
* 70b7445 Reland Added Badge.count constructor (flutter/flutter#115566)

* 31f8631 fa7e1965e [Impeller] Fix glyph atlas uploads and renders (flutter/engine#37691) (flutter/flutter#115556)

* a1ea383 Label should always be aligned with text in filled input decoration (flutter/flutter#115540)

* c2b2950 Add selection feedback for both selection area and text field (flutter/flutter#115373)

* 0344407 Rev package:pub_semver to the latest version (flutter/flutter#115570)

* ac06523 Add Material 3 support for `Slider` - Part 2  (flutter/flutter#114624)

* b181d07 a2fa4e9 cirrus to luci (flutter/plugins#6711) (flutter/flutter#115573)

* e1efd0d b241e69fd [ui] reland add docs to FragmentShader (flutter/engine#37699) (flutter/flutter#115578)

* efb0694 Remove unused flutter_attach_test_fuchsia (flutter/flutter#115515)

* a5a368c 487ee66f6 [macOS] Merge FlutterRenderer and implementation (flutter/engine#37696) (flutter/flutter#115581)

* 4ff7fc6 Fixes a bug where dragging a collapsed handle in TextField does not vibrate (flutter/flutter#115586)

* 20be280 da9534ea6 [macOS] Consolidate external texture classes (flutter/engine#37703) (flutter/flutter#115585)

* 8a7102e Roll Flutter Engine from da9534ea6534 to d955a72c5604 (3 revisions) (flutter/flutter#115589)

* e1903a2 Roll Flutter Engine from d955a72c5604 to 1e1a4ab3c993 (4 revisions) (flutter/flutter#115592)

* 78390a0 Roll Flutter Engine from 1e1a4ab3c993 to b65c24ce621a (2 revisions) (flutter/flutter#115598)

* 75a0a72 [devicelab] measure entire release folder size, zipped (flutter/flutter#115597)

* 59a01b6 Roll Flutter Engine from b65c24ce621a to 49b52db603cc (3 revisions) (flutter/flutter#115606)

* ec03f1c Revert "[devicelab] measure entire release folder size, zipped (#115597)" (flutter/flutter#115609)

* 710e708 Improve showSnackBar documentation (flutter/flutter#114612)

* 915c3de Roll Flutter Engine from 49b52db603cc to 80b25a302b4c (2 revisions) (flutter/flutter#115608)

* 450f162 Roll Flutter Engine from 80b25a302b4c to e812122e4060 (2 revisions) (flutter/flutter#115614)

* 0b33b85 [devicelab] measure entire release folder size, zipped (flutter/flutter#115612)

* 9379c32 Revert "[devicelab] measure entire release folder size, zipped (#115612)" (flutter/flutter#115617)

* b746557 f27666d2f [macOS] Merge FlutterBackingStore implementations (flutter/engine#37730) (flutter/flutter#115616)

* 5487a7d Roll Flutter Engine from f27666d2f4da to 39f546585b0b (2 revisions) (flutter/flutter#115618)

* f261c2f update comments (flutter/flutter#115603)

* 9c9f781 04aea3c47 iOS PlatformView only sets a maskView when necessary (flutter/engine#37434) (flutter/flutter#115621)

* 6926960 4ca2c1d78 Roll Skia from 55f654bf5cff to 9d56e506b4df (13 revisions) (flutter/engine#37739) (flutter/flutter#115625)

* de4c0b1 Use `double.isNaN` instead of `... == double.nan` (which is always false) (flutter/flutter#115424)

* a655f85 a62736769 Roll Skia from 9d56e506b4df to d693b4b9fe5e (5 revisions) (flutter/engine#37741) (flutter/flutter#115640)

* 18c8727 f092cd826 Roll Fuchsia Mac SDK from SVtX810D2U_ZgBcpx... to tklUfTsSOVKk49tYq... (flutter/engine#37742) (flutter/flutter#115643)
shogohida pushed a commit to shogohida/flutter that referenced this pull request Dec 7, 2022
@engine-flutter-autoroll @shogohida
fa7e1965e [Impeller] Fix glyph atlas uploads and renders (flutter/eng…
583f285 
…ine#37691) (flutter#115556)
gspencergoog pushed a commit to gspencergoog/flutter that referenced this pull request Jan 19, 2023
@engine-flutter-autoroll @gspencergoog
fa7e1965e [Impeller] Fix glyph atlas uploads and renders (flutter/eng…
408b74e 
…ine#37691) (flutter#115556)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bdero bdero bdero approved these changes

@chinmaygarde chinmaygarde Awaiting requested review from chinmaygarde

@dnfield dnfield Awaiting requested review from dnfield

Assignees
No one assigned
Labels
needs tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Impeller] Fix SDF Text rendering on Vulkan
2 participants
@iskakaushik @bdero