Skip to content
This repository has been archived by the owner on Feb 25, 2025. It is now read-only.

[web] Check for cached browsers on LUCI #37721

Merged
merged 6 commits into from
Nov 17, 2022

Conversation

harryterkelsen
Copy link
Contributor

Engine-side change for flutter/flutter#115404

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the platform-web Code specifically for the web engine label Nov 17, 2022
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@harryterkelsen harryterkelsen added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 17, 2022
@harryterkelsen harryterkelsen merged commit 49b52db into flutter:main Nov 17, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 17, 2022
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Nov 18, 2022
…115606)

* de54c4071 Roll Skia from 89f8ba6f749d to 55f654bf5cff (8 revisions) (flutter/engine#37725)

* 3634b6b39 Roll Fuchsia Mac SDK from -Y6svEFnJjmSFQGPZ... to SVtX810D2U_ZgBcpx... (flutter/engine#37726)

* 49b52db60 [web] Check for cached browsers on LUCI (flutter/engine#37721)
harryterkelsen pushed a commit that referenced this pull request Nov 18, 2022
shogohida pushed a commit to shogohida/flutter that referenced this pull request Dec 7, 2022
…lutter#115606)

* de54c4071 Roll Skia from 89f8ba6f749d to 55f654bf5cff (8 revisions) (flutter/engine#37725)

* 3634b6b39 Roll Fuchsia Mac SDK from -Y6svEFnJjmSFQGPZ... to SVtX810D2U_ZgBcpx... (flutter/engine#37726)

* 49b52db60 [web] Check for cached browsers on LUCI (flutter/engine#37721)
gspencergoog pushed a commit to gspencergoog/flutter that referenced this pull request Jan 19, 2023
…lutter#115606)

* de54c4071 Roll Skia from 89f8ba6f749d to 55f654bf5cff (8 revisions) (flutter/engine#37725)

* 3634b6b39 Roll Fuchsia Mac SDK from -Y6svEFnJjmSFQGPZ... to SVtX810D2U_ZgBcpx... (flutter/engine#37726)

* 49b52db60 [web] Check for cached browsers on LUCI (flutter/engine#37721)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
autosubmit Merge PR when tree becomes green via auto submit App needs tests platform-web Code specifically for the web engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants