This repository has been archived by the owner on Feb 25, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6k
[web] Check for cached browsers on LUCI #37721
Merged
harryterkelsen
merged 6 commits into
flutter:main
from
harryterkelsen:tests-use-cached-browsers
Nov 17, 2022
Merged
[web] Check for cached browsers on LUCI #37721
harryterkelsen
merged 6 commits into
flutter:main
from
harryterkelsen:tests-use-cached-browsers
Nov 17, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
yjbanov
approved these changes
Nov 17, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 17, 2022
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 18, 2022
…115606) * de54c4071 Roll Skia from 89f8ba6f749d to 55f654bf5cff (8 revisions) (flutter/engine#37725) * 3634b6b39 Roll Fuchsia Mac SDK from -Y6svEFnJjmSFQGPZ... to SVtX810D2U_ZgBcpx... (flutter/engine#37726) * 49b52db60 [web] Check for cached browsers on LUCI (flutter/engine#37721)
harryterkelsen
pushed a commit
that referenced
this pull request
Nov 18, 2022
This reverts commit 49b52db.
shogohida
pushed a commit
to shogohida/flutter
that referenced
this pull request
Dec 7, 2022
…lutter#115606) * de54c4071 Roll Skia from 89f8ba6f749d to 55f654bf5cff (8 revisions) (flutter/engine#37725) * 3634b6b39 Roll Fuchsia Mac SDK from -Y6svEFnJjmSFQGPZ... to SVtX810D2U_ZgBcpx... (flutter/engine#37726) * 49b52db60 [web] Check for cached browsers on LUCI (flutter/engine#37721)
gspencergoog
pushed a commit
to gspencergoog/flutter
that referenced
this pull request
Jan 19, 2023
…lutter#115606) * de54c4071 Roll Skia from 89f8ba6f749d to 55f654bf5cff (8 revisions) (flutter/engine#37725) * 3634b6b39 Roll Fuchsia Mac SDK from -Y6svEFnJjmSFQGPZ... to SVtX810D2U_ZgBcpx... (flutter/engine#37726) * 49b52db60 [web] Check for cached browsers on LUCI (flutter/engine#37721)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
autosubmit
Merge PR when tree becomes green via auto submit App
needs tests
platform-web
Code specifically for the web engine
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Engine-side change for flutter/flutter#115404
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.