Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix new unnecessary_parenthesis diagnostics. #38291

Merged
merged 1 commit into from
Dec 14, 2022
Merged

Fix new unnecessary_parenthesis diagnostics. #38291

merged 1 commit into from
Dec 14, 2022

Conversation

pq
Copy link
Contributor

@pq pq commented Dec 14, 2022 •
edited
Loading

These will get flagged w/ the latest linter.

See try failure and linter roll PR.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@pq pq requested a review from dnfield December 14, 2022 19:33
@pq pq mentioned this pull request Nov 19, 2024
Closed
10 tasks
@jason-simmons jason-simmons added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 14, 2022
@auto-submit auto-submit bot merged commit db5605e into flutter:main Dec 14, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 14, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 14, 2022
@engine-flutter-autoroll
db5605ea7 Fix new unnecessary_parenthesis diagnostics. (flutter/eng…
8410daa 
…ine#38291)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Dec 15, 2022
@engine-flutter-autoroll
Roll Flutter Engine from 0a6a4a58f4f7 to db5605ea7115 (11 revisions) (#…
9aa2ea1 
…117109)

* 1a1b1feee Roll Skia from 537e1e8c1ca6 to 729ccbfb87bc (7 revisions) (flutter/engine#38277)

* 3b18821e1 Roll Fuchsia Linux SDK from A0jnUUORf2LQu1z2V... to e2lfUFBW5ddtTZBbw... (flutter/engine#38280)

* beb94ea2c Roll Skia from 729ccbfb87bc to 3171deabd88a (4 revisions) (flutter/engine#38279)

* 8f9071ab9 Roll Fuchsia Mac SDK from FQQdl8AGAsALFniHl... to u-tC0QEGUT4xQ4KOo... (flutter/engine#38282)

* aa78cd8d6 add link to website (flutter/engine#38273)

* 955447b35 pylint all Python scripts under testing/ (flutter/engine#38268)

* 3f22e1958 [web] correct float count in runtime effect (flutter/engine#38288)

* 479bb736f Fix issues related to keyboard inset (flutter/engine#37719)

* 6cd85616b [macOS] Refactor rendering infrastructure (flutter/engine#37789)

* d1533d12b [web] Make Canvaskit's malloc more useful (flutter/engine#38130)

* db5605ea7 Fix new `unnecessary_parenthesis` diagnostics. (flutter/engine#38291)
loic-sharma pushed a commit to loic-sharma/flutter-engine that referenced this pull request Dec 16, 2022
@pq @loic-sharma
Fix new unnecessary_parenthesis diagnostics. (flutter#38291)
a3e3fbe 
These will get flagged w/ the latest linter.

See, [try failure](https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket/8794866247739072257/+/u/analyze_flutter_plugins/stdout) and [linter roll PR](https://dart-review.googlesource.com/c/sdk/+/275044).
loic-sharma pushed a commit to loic-sharma/flutter-engine that referenced this pull request Jan 3, 2023
@pq @loic-sharma
Fix new unnecessary_parenthesis diagnostics. (flutter#38291)
a8eb4df 
These will get flagged w/ the latest linter.

See, [try failure](https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket/8794866247739072257/+/u/analyze_flutter_plugins/stdout) and [linter roll PR](https://dart-review.googlesource.com/c/sdk/+/275044).
gspencergoog pushed a commit to gspencergoog/flutter that referenced this pull request Jan 19, 2023
@engine-flutter-autoroll @gspencergoog
Roll Flutter Engine from 0a6a4a58f4f7 to db5605ea7115 (11 revisions) (f…
bd6ddc4 
…lutter#117109)

* 1a1b1feee Roll Skia from 537e1e8c1ca6 to 729ccbfb87bc (7 revisions) (flutter/engine#38277)

* 3b18821e1 Roll Fuchsia Linux SDK from A0jnUUORf2LQu1z2V... to e2lfUFBW5ddtTZBbw... (flutter/engine#38280)

* beb94ea2c Roll Skia from 729ccbfb87bc to 3171deabd88a (4 revisions) (flutter/engine#38279)

* 8f9071ab9 Roll Fuchsia Mac SDK from FQQdl8AGAsALFniHl... to u-tC0QEGUT4xQ4KOo... (flutter/engine#38282)

* aa78cd8d6 add link to website (flutter/engine#38273)

* 955447b35 pylint all Python scripts under testing/ (flutter/engine#38268)

* 3f22e1958 [web] correct float count in runtime effect (flutter/engine#38288)

* 479bb736f Fix issues related to keyboard inset (flutter/engine#37719)

* 6cd85616b [macOS] Refactor rendering infrastructure (flutter/engine#37789)

* d1533d12b [web] Make Canvaskit's malloc more useful (flutter/engine#38130)

* db5605ea7 Fix new `unnecessary_parenthesis` diagnostics. (flutter/engine#38291)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jason-simmons jason-simmons jason-simmons approved these changes

@dnfield dnfield Awaiting requested review from dnfield

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pq @jason-simmons