This repository has been archived by the owner on Feb 25, 2025. It is now read-only.
Clarify dispatch semantics action id parameter #38356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
test-exempt: code refactor with no semantic change |
cbracken
changed the title
justinmc
approved these changes
Dec 16, 2022
cbracken
force-pushed
the
semantics-node-id
branch
from
16ce331 to
a15f445
Compare
Previously the embedder API documented this as an action ID, but it's actually the semantics node ID. This fixes the docs and renames the parameter to clarify its purpose.
cbracken
force-pushed
the
semantics-node-id
branch
from
a15f445 to
a5a0d73
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 16, 2022
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 17, 2022
…117246) * 1fe1ec414 Clarify semantics action dispatch id parameter (flutter/engine#38356) * 985f4ac51 Ensure licenses excluded file list has newline at EOF (flutter/engine#38354) * 4097c333f Update documentation to use `--local-web-sdk` flags. (flutter/engine#38328) * 60cf34e2a Remove DisplayList's dependency on SkAutoTMalloc (flutter/engine#38359)
loic-sharma
pushed a commit
to loic-sharma/flutter-engine
that referenced
this pull request
Jan 3, 2023
Previously the embedder API documented this as an action ID, but it's actually the semantics node ID. This fixes the docs and renames the parameter to clarify its purpose. This callback is registered in the framework render bindings: https://github.com/flutter/flutter/blob/9102f2fe0bd26db6074ac4a17785296cd341ecb9/packages/flutter/lib/src/rendering/binding.dart#L43 Handled by `_handleSemanticsAction`: https://github.com/flutter/flutter/blob/9102f2fe0bd26db6074ac4a17785296cd341ecb9/packages/flutter/lib/src/rendering/binding.dart#L360-L366 Which invokes `SemanticsOwner.performAction`, where the node is looked up by ID: https://github.com/flutter/flutter/blob/9102f2fe0bd26db6074ac4a17785296cd341ecb9/packages/flutter/lib/src/semantics/semantics.dart#L3258-L3277
gspencergoog
pushed a commit
to gspencergoog/flutter
that referenced
this pull request
Jan 19, 2023
…lutter#117246) * 1fe1ec414 Clarify semantics action dispatch id parameter (flutter/engine#38356) * 985f4ac51 Ensure licenses excluded file list has newline at EOF (flutter/engine#38354) * 4097c333f Update documentation to use `--local-web-sdk` flags. (flutter/engine#38328) * 60cf34e2a Remove DisplayList's dependency on SkAutoTMalloc (flutter/engine#38359)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the embedder API incorrectly documented this as an action ID, but it's actually the semantics node ID. This fixes the docs and renames the parameter to clarify its purpose.
This callback is registered in the framework render bindings:
https://github.com/flutter/flutter/blob/9102f2fe0bd26db6074ac4a17785296cd341ecb9/packages/flutter/lib/src/rendering/binding.dart#L43
Handled by
_handleSemanticsAction:https://github.com/flutter/flutter/blob/9102f2fe0bd26db6074ac4a17785296cd341ecb9/packages/flutter/lib/src/rendering/binding.dart#L360-L366
Which invokes
SemanticsOwner.performAction, where the node is looked up by ID:https://github.com/flutter/flutter/blob/9102f2fe0bd26db6074ac4a17785296cd341ecb9/packages/flutter/lib/src/semantics/semantics.dart#L3258-L3277
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.