Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[web] Reduce code size impact of fallback font data #38787

Merged
merged 2 commits into from
Jan 17, 2023
Merged

[web] Reduce code size impact of fallback font data #38787

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a026aed
[web] Reduce code size impact of fallback font data
mdebbar Jan 11, 2023
6419a6f
fix rangeEnd vs rangeLength mistake
mdebbar Jan 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 33 additions & 5 deletions lib/web_ui/dev/generate_fallback_font_data.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,9 +111,10 @@ class GenerateFallbackFontDataCommand extends Command<bool>
sb.writeln('// dev/generate_fallback_font_data.dart');
sb.writeln("import 'noto_font.dart';");
sb.writeln();
sb.writeln('const List<NotoFont> fallbackFonts = <NotoFont>[');
sb.writeln('final List<NotoFont> fallbackFonts = <NotoFont>[');

for (final String family in fallbackFonts) {
sb.write(" NotoFont('$family', '${urlForFamily[family]!}', ");
sb.writeln(" NotoFont('$family', '${urlForFamily[family]!}',");
final List<String> starts = <String>[];
final List<String> ends = <String>[];
for (final String range in charsetForFamily[family]!.split(' ')) {
Expand All @@ -126,15 +127,22 @@ class GenerateFallbackFontDataCommand extends Command<bool>
ends.add(parts[1]);
}
}
sb.write('<int>[');

// Print the unicode ranges in a readable format for easier review. This
// shouldn't affect code size because comments are removed in release mode.
sb.write(' // <int>[');
for (final String start in starts) {
sb.write('0x$start,');
}
sb.write('], <int>[');
sb.writeln('],');
sb.write(' // <int>[');
for (final String end in ends) {
sb.write('0x$end,');
}
sb.writeln(']),');
sb.writeln(']');

sb.writeln(" '${_packFontRanges(starts, ends)}',");
sb.writeln(' ),');
}
sb.writeln('];');

Expand Down Expand Up @@ -293,3 +301,23 @@ const List<String> fallbackFonts = <String>[
'Noto Sans Yi',
'Noto Sans Zanabazar Square',
];

String _packFontRanges(List<String> starts, List<String> ends) {
assert(starts.length == ends.length);

final StringBuffer sb = StringBuffer();

for (int i = 0; i < starts.length; i++) {
final int start = int.parse(starts[i], radix: 16);
final int end = int.parse(ends[i], radix: 16);

sb.write(start.toRadixString(36));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

36 just to get maximum "compression"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. To encode the integer in as few characters as possible.

sb.write('|');
if (start != end) {
sb.write((end - start).toRadixString(36));
}
sb.write(';');
}

return sb.toString();
}
Loading