Skip to content
This repository has been archived by the owner on Feb 25, 2025. It is now read-only.

Migrate Linux Arm Host Engine to engine v2. #41555

Merged
merged 2 commits into from
Apr 28, 2023
Merged

Migrate Linux Arm Host Engine to engine v2. #41555

merged 2 commits into from
Apr 28, 2023

Conversation

godofredoc
Copy link
Contributor

The artifacts from legacy and engine v2 builders are identical. This PR is moving the legacy builder to staging and updates engine v2 build to upload the artifacts to production.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

The artifacts from legacy and engine v2 builders are identical. This PR
is moving the legacy builder to staging and updates engine v2 build to
upload the artifacts to production.
@godofredoc godofredoc requested a review from zanderso April 27, 2023 17:51
@zanderso
Copy link
Member

Looks like Mac clang-tidy timed-out due to the mysterious slowness issue.

@godofredoc
Copy link
Contributor Author

Looks like Mac clang-tidy timed-out due to the mysterious slowness issue.

Looks like Mac clang-tidy timed-out due to the mysterious slowness issue.

The random slow builds on arm machines is being tracked here: flutter/flutter#119750

@godofredoc godofredoc added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 28, 2023
@auto-submit auto-submit bot merged commit 98b6fab into flutter:main Apr 28, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 28, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Apr 28, 2023
…125690)

flutter/engine@1d25906...98b6fab

2023-04-28 [email protected] Migrate Linux Arm Host Engine to engine v2. (flutter/engine#41555)
2023-04-28 [email protected] Roll Fuchsia Mac SDK from Rk2iPE0_H1vjuGV4e... to kNDuhglIFq_xEt5n3... (flutter/engine#41582)
2023-04-28 [email protected] [Impeller] Manage the onscreen stencil in EntityPass (flutter/engine#41563)
2023-04-28 [email protected] Revert "Reland: [Impeller] Use a device buffer for SkBitmap allocation, use Linear texture on Metal backend. " (flutter/engine#41567)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from Rk2iPE0_H1vj to kNDuhglIFq_x

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@godofredoc godofredoc deleted the migrate_linux_arm branch April 28, 2023 17:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants