Skip to content
This repository has been archived by the owner on Feb 25, 2025. It is now read-only.

Fix embedder glfw examples cmake subdirectory path error #48013

Merged
merged 4 commits into from
Nov 20, 2023

Conversation

hongeSunCoder
Copy link
Contributor

@hongeSunCoder hongeSunCoder commented Nov 14, 2023

Fix just a cmake glfw subdirectory path error in embedder examples.

Fix: flutter/flutter#138340

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is [test-exempt]. See [testing the engine] for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the [CLA].
  • All existing and new tests are passing.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie or stuartmorgan on the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Copy link

google-cla bot commented Nov 14, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@jonahwilliams jonahwilliams requested a review from bdero November 20, 2023 18:46
Copy link
Member

@bdero bdero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bdero bdero added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 20, 2023
Copy link
Contributor

auto-submit bot commented Nov 20, 2023

auto label is removed for flutter/engine/48013, due to This PR has not met approval requirements for merging. You are not a member of flutter-hackers and need 1 more review(s) in order to merge this PR.

  • Merge guidelines: You need at least one approved review if you are already part of flutter-hackers or two member reviews if you are not a flutter-hacker before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Nov 20, 2023
@bdero bdero added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 20, 2023
Copy link
Member

@zanderso zanderso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but as the message says, this PR will need a test exemption requested in the Discord room.

@bdero bdero removed the autosubmit Merge PR when tree becomes green via auto submit App label Nov 20, 2023
@bdero
Copy link
Member

bdero commented Nov 20, 2023

Whoops, slipped my mind. Asked for one in Discord.

@Hixie
Copy link
Contributor

Hixie commented Nov 20, 2023

test-exempt: build script

@bdero bdero added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 20, 2023
@auto-submit auto-submit bot merged commit 97cf063 into flutter:main Nov 20, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Nov 21, 2023
…138765)

flutter/engine@6e8e55e...39fb458

2023-11-20 [email protected] Make `runtime/...` and `shell/common/...` compatible with `.clang-tidy`. (flutter/engine#48158)
2023-11-20 [email protected] Fix embedder glfw examples cmake subdirectory path error (flutter/engine#48013)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

engine embedder glfw examples not update
5 participants