Skip unexpected events in MultiPlatformViewBackgroundForegroundScenario #48456

vashworth · 2023-11-28T16:33:20Z

Was first attempted to fix in #48096, but that was not reliable since it's all asynchronous.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
I listed at least one issue that this PR fixes in the description above.
I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
I updated/added relevant documentation (doc comments with ///).
I signed the CLA.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

flutter-dashboard · 2023-11-28T16:33:23Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie or stuartmorgan on the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

vashworth · 2023-11-28T17:09:47Z

I tested it locally to make sure it passes, but also ran in CI: https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20mac_unopt/13178/overview

hellohuanlin · 2023-11-28T19:45:31Z

testing/scenario_app/lib/src/platform_view.dart

-    if (!_firstFrameBegan) {
-      channelBuffers.setListener('flutter/lifecycle', _onPlatformMessage);
-    }
-    _firstFrameBegan = true;


is this change also necessary to fix the issue? will moving this call from firstFrame to the init cause any problem?

This part of the change is basically just undoing my first attempt at a fix (#48096), which was still flakey. So no, it shouldn't cause any problems as this was as the code originally was

stuartmorgan · 2023-11-28T19:51:13Z

test-exempt: is a test

…oundScenario (flutter/engine#48456)

…139172) flutter/engine@97ede15...01fcec7 2023-11-28 [email protected] Skip unexpected events in MultiPlatformViewBackgroundForegroundScenario (flutter/engine#48456) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…io (flutter#48456) Fixes flutter/flutter#138193. Was first attempted to fix in flutter#48096, but that was not reliable since it's all asynchronous. [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style

…undForegroundScenar… (#49247) â�¦io (#48456) Fixes flutter/flutter#138193. Was first attempted to fix in #48096, but that was not reliable since it's all asynchronous. ------------------------------------------- cherry pick to fix mac unopt failures on stable branch: https://flutter-dashboard.appspot.com/#/build?repo=engine&branch=flutter-3.16-candidate.0

…lutter#139172) flutter/engine@97ede15...01fcec7 2023-11-28 [email protected] Skip unexpected events in MultiPlatformViewBackgroundForegroundScenario (flutter/engine#48456) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

* [CP] Fix _availability_version_check for iOS 11 and 12 (flutter#48926) CP of flutter@5587d26 into 3.16 for flutter/flutter#138711. * [CP] [Impeller] Turn off Aiks bounds tracking for filtered SaveLayers. (flutter#49198) Cherry-pick for flutter#49076. For issue: flutter/flutter#139294 * [CP] Fix for AnimatedOpacity affects blended color overlay render (flutter#49190) This PR cherry-picks the following two commits: flutter@2dbc5d2 flutter@0b0fab8 to address flutter/flutter#139571 * [cherrypick-stable]Skip unexpected events in MultiPlatformViewBackgroundForegroundScenar… (flutter#49247) â�¦io (flutter#48456) Fixes flutter/flutter#138193. Was first attempted to fix in flutter#48096, but that was not reliable since it's all asynchronous. ------------------------------------------- cherry pick to fix mac unopt failures on stable branch: https://flutter-dashboard.appspot.com/#/build?repo=engine&branch=flutter-3.16-candidate.0 --------- Co-authored-by: Zachary Anderson <[email protected]> Co-authored-by: Brandon DeRosier <[email protected]> Co-authored-by: Xilai Zhang <[email protected]>

Skip unexpected events in MultiPlatformViewBackgroundForegroundScenario

9283eaa

change config back to macOS 12

59de970

vashworth requested a review from hellohuanlin November 28, 2023 17:54

hellohuanlin reviewed Nov 28, 2023

View reviewed changes

hellohuanlin approved these changes Nov 28, 2023

View reviewed changes

vashworth added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 28, 2023

auto-submit bot merged commit 01fcec7 into flutter:main Nov 28, 2023

engine-flutter-autoroll mentioned this pull request Nov 28, 2023

Roll Flutter Engine from 97ede154dcd8 to 01fcec7214db (1 revision) flutter/flutter#139172

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 28, 2023

01fcec721 Skip unexpected events in MultiPlatformViewBackgroundForegr…

0f5fc89

…oundScenario (flutter/engine#48456)

XilaiZhang mentioned this pull request Dec 19, 2023

[cherrypick-stable]Skip unexpected events in MultiPlatformViewBackgroundForegroundScenar… #49247

Merged

matanlurey mentioned this pull request Feb 26, 2024

Scenario app incorrectly uses ChannelBuffers, causing log spam flutter/flutter#144155

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Skip unexpected events in MultiPlatformViewBackgroundForegroundScenario #48456

Skip unexpected events in MultiPlatformViewBackgroundForegroundScenario #48456

vashworth commented Nov 28, 2023 •

edited

Loading

flutter-dashboard bot commented Nov 28, 2023

vashworth commented Nov 28, 2023

hellohuanlin Nov 28, 2023

vashworth Nov 28, 2023 •

edited

Loading

hellohuanlin Nov 28, 2023

stuartmorgan commented Nov 28, 2023

Skip unexpected events in MultiPlatformViewBackgroundForegroundScenario #48456

Skip unexpected events in MultiPlatformViewBackgroundForegroundScenario #48456

Conversation

vashworth commented Nov 28, 2023 • edited Loading

Pre-launch Checklist

flutter-dashboard bot commented Nov 28, 2023

vashworth commented Nov 28, 2023

hellohuanlin Nov 28, 2023

Choose a reason for hiding this comment

vashworth Nov 28, 2023 • edited Loading

Choose a reason for hiding this comment

hellohuanlin Nov 28, 2023

Choose a reason for hiding this comment

stuartmorgan commented Nov 28, 2023

vashworth commented Nov 28, 2023 •

edited

Loading

vashworth Nov 28, 2023 •

edited

Loading