[Impeller] distinguish between no clear color and transparent black clear color. #49038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
gaaclarke
approved these changes
Dec 14, 2023
impeller/entity/entity_pass.cc
Outdated
Comment on lines
345
to
346
| GetClearColor(render_target.GetRenderTargetSize()) | ||
| .value_or(Color::BlackTransparent())); |
There was a problem hiding this comment.
We should pull out this constant or pull out a helper function.
There was a problem hiding this comment.
GetClearColorOrTransparentBlack()?
There was a problem hiding this comment.
Here are some options. I think "OrDefault" is more succinct. I'm fine with either though.
GetClearColor(render_target.GetRenderTargetSize())
.value_or(kDefaultClearColor);OrDefaultClearColor(
GetClearColor(render_target.GetRenderTargetSize()))GetClearColorOrDefault(render_target.GetRenderTargetSize())There was a problem hiding this comment.
Went with OrDefault, Thanks!
|
Did you intend for the new golden image to draw just white? We should fix that. |
|
It needs to draw transparent black, for reasons :) Without this change it is magenta on macOS. |
|
Golden file changes are available for triage from new commit, Click here to view. |
jonahwilliams
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 14, 2023
…nt black clear color. (flutter/engine#49038)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 14, 2023
…140180) flutter/engine@0e7248d...0b0fab8 2023-12-14 [email protected] [Impeller] distinguish between no clear color and transparent black clear color. (flutter/engine#49038) 2023-12-14 [email protected] Unpin mac_toolchain version (flutter/engine#48994) 2023-12-14 [email protected] [Impeller] Turned on new blur. (flutter/engine#48472) 2023-12-14 [email protected] Remove unused metadata in DEPS from vuln scanning (flutter/engine#48995) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
auto-submit bot
added a commit
to flutter/flutter
that referenced
this pull request
Dec 15, 2023
…isions)" (#140194) Reverts #140180 Initiated by: zanderso This change reverts the following previous change: Original Description: flutter/engine@0e7248d...0b0fab8 2023-12-14 [email protected] [Impeller] distinguish between no clear color and transparent black clear color. (flutter/engine#49038) 2023-12-14 [email protected] Unpin mac_toolchain version (flutter/engine#48994) 2023-12-14 [email protected] [Impeller] Turned on new blur. (flutter/engine#48472) 2023-12-14 [email protected] Remove unused metadata in DEPS from vuln scanning (flutter/engine#48995) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 15, 2023
…nt black clear color. (flutter/engine#49038)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 15, 2023
…140195) flutter/engine@0e7248d...4cb3ba7 2023-12-15 [email protected] Roll Skia from 79f23e8d8b5d to cd2f06086c96 (1 revision) (flutter/engine#49069) 2023-12-15 [email protected] Roll Dart SDK from 0471164827b9 to f1e37ed8917e (1 revision) (flutter/engine#49065) 2023-12-15 [email protected] [Impeller] impellerc: delete unused code (flutter/engine#49061) 2023-12-15 [email protected] [Impeller] split out gradient tests from aiks_unittests (flutter/engine#49050) 2023-12-15 [email protected] Revert "[Impeller] Turned on new blur." (flutter/engine#49062) 2023-12-14 [email protected] Fix header-guard naming convention in `shell/`. (flutter/engine#49006) 2023-12-14 [email protected] Manual roll of Dart SDK from a677378ae254 to 0471164827b9 (flutter/engine#49054) 2023-12-14 [email protected] Rename `font-subset` to `font_subset`. (flutter/engine#49051) 2023-12-14 [email protected] Roll Skia from 92935b91193a to 79f23e8d8b5d (1 revision) (flutter/engine#49056) 2023-12-14 [email protected] Suppress warning for the new Activity library. (flutter/engine#49046) 2023-12-14 [email protected] [Impeller] distinguish between no clear color and transparent black clear color. (flutter/engine#49038) 2023-12-14 [email protected] Unpin mac_toolchain version (flutter/engine#48994) 2023-12-14 [email protected] [Impeller] Turned on new blur. (flutter/engine#48472) 2023-12-14 [email protected] Remove unused metadata in DEPS from vuln scanning (flutter/engine#48995) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
zanderso
pushed a commit
to zanderso/engine
that referenced
this pull request
Dec 15, 2023
…lear color. (flutter#49038) If we clear to transparent black, we're not forcing the pass to be constructed. Change the entity pass API so that we can tell the difference between clearing transparent black and not having a clear color. In flutter/flutter#139571 , the app is creating a layer that is clearing to a transparent color, which is getting skipped. That invalid texture is fed into a blend which produces either black or magenta error texture. Fixes flutter/flutter#139571
zanderso
pushed a commit
to zanderso/engine
that referenced
this pull request
Dec 15, 2023
…lear color. (flutter#49038) If we clear to transparent black, we're not forcing the pass to be constructed. Change the entity pass API so that we can tell the difference between clearing transparent black and not having a clear color. In flutter/flutter#139571 , the app is creating a layer that is clearing to a transparent color, which is getting skipped. That invalid texture is fed into a blend which produces either black or magenta error texture. Fixes flutter/flutter#139571
zanderso
pushed a commit
to zanderso/engine
that referenced
this pull request
Dec 18, 2023
…lear color. (flutter#49038) If we clear to transparent black, we're not forcing the pass to be constructed. Change the entity pass API so that we can tell the difference between clearing transparent black and not having a clear color. In flutter/flutter#139571 , the app is creating a layer that is clearing to a transparent color, which is getting skipped. That invalid texture is fed into a blend which produces either black or magenta error texture. Fixes flutter/flutter#139571
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we clear to transparent black, we're not forcing the pass to be constructed. Change the entity pass API so that we can tell the difference between clearing transparent black and not having a clear color.
In flutter/flutter#139571 , the app is creating a layer that is clearing to a transparent color, which is getting skipped. That invalid texture is fed into a blend which produces either black or magenta error texture.
Fixes flutter/flutter#139571