This repository has been archived by the owner on Feb 25, 2025. It is now read-only.
Use new SurfaceProducer external texture class for rendering platform views #49201
+202
−63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
johnmccutchan
force-pushed
the
surface_producer_platform_views
branch
3 times, most recently
from
43278ba to
e90c27c
Compare
johnmccutchan
added
the
autosubmit
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
This is incorrectly attributed to my PR. I've filed a bug |
dnfield
reviewed
Dec 19, 2023
shell/platform/android/io/flutter/embedding/engine/renderer/FlutterRenderer.java
Show resolved
Hide resolved
dnfield
reviewed
Dec 19, 2023
shell/platform/android/io/flutter/embedding/engine/renderer/FlutterRenderer.java
Outdated
Show resolved
Hide resolved
dnfield
reviewed
Dec 19, 2023
shell/platform/android/io/flutter/embedding/engine/renderer/FlutterRenderer.java
Outdated
Show resolved
Hide resolved
dnfield
approved these changes
Dec 19, 2023
… views - Fix lots of bugs in the implementation of ImageReaderSurfaceProducer - Add test that we drop frames produced from the wrong size - Hookup platform views to use new external texture class
johnmccutchan
force-pushed
the
surface_producer_platform_views
branch
from
8b212a8 to
c468624
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 19, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 19, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 19, 2023
…140412) flutter/engine@187334c...3f45f9d 2023-12-19 [email protected] Roll Skia from 541f16af8b3e to df1a7ccbdc97 (3 revisions) (flutter/engine#49250) 2023-12-19 [email protected] Roll Skia from 0d39fb28b32d to 541f16af8b3e (1 revision) (flutter/engine#49246) 2023-12-19 [email protected] Use new SurfaceProducer external texture class for rendering platform views (flutter/engine#49201) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
CoderDake
pushed a commit
to CoderDake/flutter
that referenced
this pull request
Dec 28, 2023
…lutter#140412) flutter/engine@187334c...3f45f9d 2023-12-19 [email protected] Roll Skia from 541f16af8b3e to df1a7ccbdc97 (3 revisions) (flutter/engine#49250) 2023-12-19 [email protected] Roll Skia from 0d39fb28b32d to 541f16af8b3e (1 revision) (flutter/engine#49246) 2023-12-19 [email protected] Use new SurfaceProducer external texture class for rendering platform views (flutter/engine#49201) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #139230
Related: #139702